Skip to content

fix(dashboards-eap): Pass along sampled flag for disabling message #89528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
narsaynorath merged 3 commits into from
Apr 15, 2025
Merged

fix(dashboards-eap): Pass along sampled flag for disabling message #89528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c46a86
fix(dashboards-eap): Pass along sampled flag for disabling message
narsaynorath Apr 14, 2025
6989f64
Merge branch 'master' into nar/fix/dashboards-eap-pass-along-sampled-…
narsaynorath Apr 15, 2025
bf7b6d2
Fix typing
narsaynorath Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions static/app/views/dashboards/widgetCard/chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ type WidgetCardChartProps = Pick<
confidence?: Confidence;
expandNumbers?: boolean;
isMobile?: boolean;
isSampled?: boolean;
legendOptions?: LegendComponentOption;
minTableColumnWidth?: string;
noPadding?: boolean;
Expand Down Expand Up @@ -281,6 +282,7 @@ class WidgetCardChart extends Component<WidgetCardChartProps> {
confidence,
showConfidenceWarning,
sampleCount,
isSampled,
} = this.props;

if (errorMessage) {
Expand Down Expand Up @@ -552,6 +554,7 @@ class WidgetCardChart extends Component<WidgetCardChartProps> {
confidence={confidence}
sampleCount={sampleCount}
topEvents={topEventsCountExcludingOther}
isSampled={isSampled}
/>
)}
</ChartWrapper>
Expand Down
2 changes: 2 additions & 0 deletions static/app/views/dashboards/widgetCard/widgetCardChartContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export function WidgetCardChartContainer({
timeseriesResultsTypes,
confidence,
sampleCount,
isSampled,
}) => {
if (widget.widgetType === WidgetType.ISSUE) {
return (
Expand Down Expand Up @@ -172,6 +173,7 @@ export function WidgetCardChartContainer({
confidence={confidence}
sampleCount={sampleCount}
minTableColumnWidth={minTableColumnWidth}
isSampled={isSampled ?? undefined}
/>
</Fragment>
);
Expand Down
Loading