🔧 chore: fix slack notifications typing #89578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/integrations/notifications.py
Did you find this useful? React with a 👍 or 👎 |
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
commented
Apr 15, 2025
| logger = logging.getLogger("sentry.notifications") | ||
|
|
||
|
|
||
| class SlackNotifyBasicMixin(NotifyBasicMixin): |
There was a problem hiding this comment.
this doesn't need to live separately, so moved it under SlackIntegration
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #89578 +/- ##
==========================================
- Coverage 87.73% 87.73% -0.01%
==========================================
Files 10172 10172
Lines 574129 574126 -3
Branches 22612 22612
==========================================
- Hits 503728 503721 -7
- Misses 69985 69989 +4
Partials 416 416 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.