Skip to content

Conversation

shellmayr
Copy link
Member

  • API returns null when there are no errors - render this as 0% instead of <0%
    Before:
Screenshot 2025-05-15 at 13 44 28

After:
Screenshot 2025-05-15 at 13 44 19

@shellmayr shellmayr requested a review from a team as a code owner May 15, 2025 11:45
@shellmayr shellmayr requested a review from a team May 15, 2025 11:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 15, 2025
@shellmayr shellmayr enabled auto-merge (squash) May 15, 2025 12:08
@shellmayr shellmayr merged commit 9c2bcd9 into master May 15, 2025
41 checks passed
@shellmayr shellmayr deleted the shellmayr/tet-460-show-0-instead-of-0-when-api-returns-null-for-failure-rate branch May 15, 2025 12:09
shellmayr added a commit that referenced this pull request May 15, 2025
…ge (#91710)

- So far, the formatPercentage function returns `<0%` for `null` and
`undefined` values; which is not correct in any way.
- This PR explicitly returns 0% for those cases - this may not be
semantically correct in some cases, so this PR also adds an option to
define a null value.

Follow-up to #91709
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants