Skip to content

Conversation

untitaker
Copy link
Member

  • fix(span-buffer): Report exceptions from subprocess
  • fix(span-buffer): Restart flusher properly

untitaker added 2 commits May 20, 2025 16:37
sdk does not have a multiprocessing integration, so crashes in the
process do not get reported
Apparently a process cannot be restarted, need to create a new instance

Fix SENTRY-3WK7
@untitaker untitaker requested a review from a team as a code owner May 20, 2025 16:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157236 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Files with missing lines Patch % Lines
src/sentry/spans/consumers/process/flusher.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91949      +/-   ##
==========================================
+ Coverage   86.51%   87.62%   +1.10%     
==========================================
  Files       10355    10356       +1     
  Lines      587271   587372     +101     
  Branches    22586    22586              
==========================================
+ Hits       508082   514667    +6585     
+ Misses      78762    72278    -6484     
  Partials      427      427              

@untitaker untitaker changed the title fix/flusher restart fix(span-buffer): Fix crashing behavior in flusher May 21, 2025
@untitaker untitaker merged commit fa1a77d into master May 21, 2025
62 checks passed
@untitaker untitaker deleted the fix/flusher-restart branch May 21, 2025 10:48
Copy link

sentry-io bot commented May 22, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KafkaException: KafkaError{code=MSG_SIZE_TOO_LARGE,val=10,str="Unable to produce message: Broker: Message size too large"} sentry.spans.consumers.process.flusher in produce View Issue
  • ‼️ ConnectionError: Connection closed by server. sentry.spans.buffer in flush_segments View Issue
  • ‼️ ClusterError: Command # 49 (SMEMBERS b'span-buf:s:{4509370939867136:3b8d3980493a4f6b9390fc59b52788ec}:997ebadc3a0ce43e') of pipeline caused error: TTL exhausted. sentry.spans.buffer in flush_segments View Issue
  • ‼️ AskError: 12999 192.168.208.83:11054 sentry.spans.buffer in done_flush_segments View Issue
  • ‼️ TimeoutError: Timeout connecting to server sentry.spans.buffer in done_flush_segments View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
- **fix(span-buffer): Report exceptions from subprocess**
- **fix(span-buffer): Restart flusher properly**
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants