Skip to content

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jun 12, 2025

1. Overall changes
I moved around the "Seen By" stuff to save a little vertical space; it used to be directly below the message, now it's in the header
All Sections are collapseable now, saved into local storage

SCR-20250611-ozjr

2. Tags & Context changes
I split up Tags & Context, and re-used the components from Issue Details. There's no way to split up Custom tags, but everything will be shown.
Fixes REPLAY-67
SCR-20250611-ozqr

@ryan953 ryan953 requested a review from a team as a code owner June 12, 2025 00:07
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2025
@michellewzhang
Copy link
Member

michellewzhang commented Jun 12, 2025

SCR-20250612-jzqn

the built in tag dropdown exposes the user feedback in issue details -- "view other events with this tag value" goes to the issue and the search also goes to issue search

SCR-20250612-jzyc

@ryan953 ryan953 requested a review from a team as a code owner June 20, 2025 19:59
@ryan953
Copy link
Member Author

ryan953 commented Jun 20, 2025

the built in tag dropdown exposes the user feedback in issue details -- "view other events with this tag value" goes to the issue and the search also goes to issue search

Fixed! I added a new menu item to link back into feedback, and disabled all the rest that don't make sense for this case.
SCR-20250620-lqfz

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/components/events/eventTags/eventTagsTreeRow.tsx 33.33% 1 Missing and 1 partial ⚠️
.../components/feedback/feedbackItem/feedbackItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93397      +/-   ##
==========================================
- Coverage   88.03%   88.01%   -0.03%     
==========================================
  Files       10350    10287      -63     
  Lines      598214   592336    -5878     
  Branches    23227    23026     -201     
==========================================
- Hits       526651   521338    -5313     
+ Misses      71058    70566     -492     
+ Partials      505      432      -73     

@ryan953 ryan953 merged commit b53da03 into master Jun 20, 2025
47 checks passed
@ryan953 ryan953 deleted the ryan953/feedback-tags-context-collapse branch June 20, 2025 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants