feat(feedback): frontend to display summary #93567
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| import useFeedbackSummary from 'sentry/components/feedback/list/useFeedbackSummary'; | ||
| import LoadingError from 'sentry/components/loadingError'; | ||
| import Placeholder from 'sentry/components/placeholder'; | ||
| import {IconSeer} from 'sentry/icons/iconSeer'; | ||
| import {t} from 'sentry/locale'; | ||
| import {space} from 'sentry/styles/space'; | ||
| import useOrganization from 'sentry/utils/useOrganization'; | ||
|
|
||
| export default function FeedbackSummary() { | ||
| const {isError, isPending, summary, tooFewFeedbacks} = useFeedbackSummary(); | ||
|
|
||
| const organization = useOrganization(); | ||
|
|
||
| if (!organization.features.includes('user-feedback-ai-summaries')) { | ||
| return null; | ||
| } | ||
|
|
||
| if (isError) { | ||
| return <LoadingError message={t('There was an error loading the summary')} />; | ||
| } | ||
|
|
||
| if (isPending) { | ||
| return <Placeholder height="100px" />; | ||
| } | ||
|
|
||
| if (tooFewFeedbacks) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <SummaryIconContainer> | ||
| <IconSeer size="xs" /> | ||
| <SummaryContainer> | ||
| <SummaryHeader>{t('Feedback Summary')}</SummaryHeader> | ||
| <SummaryContent>{summary}</SummaryContent> | ||
| </SummaryContainer> | ||
| </SummaryIconContainer> | ||
| ); | ||
| } | ||
|
|
||
| const SummaryContainer = styled('div')` | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: ${space(1)}; | ||
| width: 100%; | ||
| `; | ||
|
|
||
| const SummaryHeader = styled('p')` | ||
| font-size: ${p => p.theme.fontSizeMedium}; | ||
| font-weight: ${p => p.theme.fontWeightBold}; | ||
| margin: 0; | ||
| `; | ||
|
|
||
| const SummaryContent = styled('p')` | ||
| font-size: ${p => p.theme.fontSizeSmall}; | ||
| color: ${p => p.theme.subText}; | ||
| margin: 0; | ||
| `; | ||
|
|
||
| const SummaryIconContainer = styled('div')` | ||
| display: flex; | ||
| flex-direction: row; | ||
vishnupsatish marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| gap: ${space(1)}; | ||
| padding: ${space(2)}; | ||
| border: 1px solid ${p => p.theme.border}; | ||
| border-radius: ${p => p.theme.borderRadius}; | ||
| align-items: baseline; | ||
| `; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import {normalizeDateTimeParams} from 'sentry/components/organizations/pageFilters/parse'; | ||
| import {useApiQuery} from 'sentry/utils/queryClient'; | ||
| import useOrganization from 'sentry/utils/useOrganization'; | ||
| import usePageFilters from 'sentry/utils/usePageFilters'; | ||
|
|
||
| type FeedbackSummaryResponse = { | ||
| numFeedbacksUsed: number; | ||
| success: boolean; | ||
| summary: string | null; | ||
| }; | ||
|
|
||
| export default function useFeedbackSummary(): { | ||
| isError: boolean; | ||
| isPending: boolean; | ||
| summary: string | null; | ||
| tooFewFeedbacks: boolean; | ||
| } { | ||
| const organization = useOrganization(); | ||
|
|
||
| const {selection} = usePageFilters(); | ||
|
|
||
| const normalizedDateRange = normalizeDateTimeParams(selection.datetime); | ||
|
Comment on lines
+20
to
+22
Contributor
Author
There was a problem hiding this comment. I've updated the way the date range filtering is done and from my testing (and looking at the code) this seems to work. Can you please have a look @ryan953 @michellewzhang?
Member
There was a problem hiding this comment. woo, fewer weird things going on! |
||
|
|
||
| const {data, isPending, isError} = useApiQuery<FeedbackSummaryResponse>( | ||
| [ | ||
| `/organizations/${organization.slug}/feedback-summary/`, | ||
| { | ||
| query: { | ||
| ...normalizedDateRange, | ||
| project: selection.projects, | ||
| }, | ||
| }, | ||
| ], | ||
| { | ||
| staleTime: 5000, | ||
| enabled: | ||
| Boolean(normalizedDateRange) && | ||
| organization.features.includes('user-feedback-ai-summaries'), | ||
| retry: 1, | ||
| } | ||
| ); | ||
|
|
||
| if (isPending) { | ||
| return { | ||
| summary: null, | ||
| isPending: true, | ||
| isError: false, | ||
| tooFewFeedbacks: false, | ||
| }; | ||
| } | ||
|
|
||
| if (isError) { | ||
| return { | ||
| summary: null, | ||
| isPending: false, | ||
| isError: true, | ||
| tooFewFeedbacks: false, | ||
| }; | ||
| } | ||
|
|
||
| return { | ||
| summary: data.summary, | ||
| isPending: false, | ||
| isError: false, | ||
| tooFewFeedbacks: data.numFeedbacksUsed === 0 && data.success === false, | ||
vishnupsatish marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.