Skip to content

docs(replay): Iterate on bulk delete blueprint #94494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

docs(replay): Iterate on bulk delete blueprint #94494

merged 1 commit into from
Jun 30, 2025

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jun 26, 2025

No description provided.

@ryan953 ryan953 requested a review from cmanallen June 26, 2025 21:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 26, 2025
cmanallen
cmanallen approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why string id?

Related pull adding a failure status #93996

@ryan953
Copy link
Member Author

ryan953 commented Jun 30, 2025 •
edited
Loading

Why string id?

We should be using strings for ID because then we don't have to worry about different number types in JS and Python, and overflows and all that stuff. Not going to do math on an id :p

@ryan953 ryan953 marked this pull request as ready for review June 30, 2025 17:58
@ryan953 ryan953 requested a review from a team as a code owner June 30, 2025 17:58
@ryan953 ryan953 merged commit 395c398 into master Jun 30, 2025
62 checks passed
@ryan953 ryan953 deleted the ryan953/bulk-replay-delete-blueprint branch June 30, 2025 18:00
andrewshie-sentry pushed a commit that referenced this pull request Jul 14, 2025
@ryan953 @andrewshie-sentry
docs(replay): Iterate on bulk delete blueprint (#94494)
16240bf
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmanallen cmanallen cmanallen approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan953 @cmanallen