Skip to content

feat(aci): add subfilters list to remaining frequency conditions #94621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

feat(aci): add subfilters list to remaining frequency conditions #94621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 62 additions & 22 deletions static/app/views/automations/components/actionFilters/eventUniqueUserFrequency.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import {RowLine} from 'sentry/components/workflowEngine/form/automationBuilderRowLine';
import {AutomationBuilderSelect} from 'sentry/components/workflowEngine/form/automationBuilderSelect';
import {tct} from 'sentry/locale';
import {ConditionBadge} from 'sentry/components/workflowEngine/ui/conditionBadge';
import {t, tct} from 'sentry/locale';
import type {SelectValue} from 'sentry/types/core';
import type {DataCondition} from 'sentry/types/workflowEngine/dataConditions';
import {DataConditionType} from 'sentry/types/workflowEngine/dataConditions';
Expand All @@ -11,45 +13,83 @@ import {
COMPARISON_INTERVAL_CHOICES,
INTERVAL_CHOICES,
} from 'sentry/views/automations/components/actionFilters/constants';
import {
SubfilterDetailsList,
SubfiltersList,
} from 'sentry/views/automations/components/actionFilters/subfiltersList';
import {useDataConditionNodeContext} from 'sentry/views/automations/components/dataConditionNodes';

export function EventUniqueUserFrequencyCountDetails({
condition,
}: {
condition: DataCondition;
}) {
return tct('Number of users affected by an issue is more than [value] [interval]', {
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(choice => choice.value === condition.comparison.interval)
?.label || condition.comparison.interval,
});
const hasSubfilters = condition.comparison.filters?.length > 0;
return (
<div>
{tct(
'Number of users affected by an issue is more than [value] [interval] [where]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.interval
)?.label || condition.comparison.interval,
where: hasSubfilters ? t('where') : null,
}
)}
{hasSubfilters && (
<SubfilterDetailsList subfilters={condition.comparison.filters} />
)}
</div>
);
}

export function EventUniqueUserFrequencyPercentDetails({
condition,
}: {
condition: DataCondition;
}) {
return tct(
'Number of users affected by an issue is [value]% higher [interval] compared to [comparison_interval]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(choice => choice.value === condition.comparison.interval)
?.label || condition.comparison.interval,
comparison_interval:
COMPARISON_INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.comparison_interval
)?.label || condition.comparison.comparison_interval,
}
const hasSubfilters = condition.comparison.filters?.length > 0;
return (
<div>
{tct(
'Number of users affected by an issue is [value]% higher [interval] compared to [comparison_interval] [where]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.interval
)?.label || condition.comparison.interval,
comparison_interval:
COMPARISON_INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.comparison_interval
)?.label || condition.comparison.comparison_interval,
where: hasSubfilters ? t('where') : null,
}
)}
{hasSubfilters && (
<SubfilterDetailsList subfilters={condition.comparison.filters} />
)}
</div>
);
}

export function EventUniqueUserFrequencyNode() {
return tct('Number of users affected by an issue is [select]', {
select: <ComparisonTypeField />,
});
const {condition} = useDataConditionNodeContext();
const hasSubfilters = condition.comparison.filters?.length > 0;

return (
<div>
<RowLine>
{tct('Number of users affected by an issue is [select] [where]', {
select: <ComparisonTypeField />,
where: hasSubfilters ? <ConditionBadge>{t('Where')}</ConditionBadge> : null,
})}
</RowLine>
<SubfiltersList />
</div>
);
}

function ComparisonTypeField() {
Expand Down
84 changes: 60 additions & 24 deletions static/app/views/automations/components/actionFilters/percentSessions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import {RowLine} from 'sentry/components/workflowEngine/form/automationBuilderRowLine';
import {AutomationBuilderSelect} from 'sentry/components/workflowEngine/form/automationBuilderSelect';
import {tct} from 'sentry/locale';
import {ConditionBadge} from 'sentry/components/workflowEngine/ui/conditionBadge';
import {t, tct} from 'sentry/locale';
import type {SelectValue} from 'sentry/types/core';
import type {DataCondition} from 'sentry/types/workflowEngine/dataConditions';
import {DataConditionType} from 'sentry/types/workflowEngine/dataConditions';
Expand All @@ -11,40 +13,74 @@ import {
COMPARISON_INTERVAL_CHOICES,
INTERVAL_CHOICES,
} from 'sentry/views/automations/components/actionFilters/constants';
import {
SubfilterDetailsList,
SubfiltersList,
} from 'sentry/views/automations/components/actionFilters/subfiltersList';
import {useDataConditionNodeContext} from 'sentry/views/automations/components/dataConditionNodes';

export function PercentSessionsCountDetails({condition}: {condition: DataCondition}) {
return tct(
'Percentage of sessions affected by an issue is more than [value] [interval]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(choice => choice.value === condition.comparison.interval)
?.label || condition.comparison.interval,
}
const hasSubfilters = condition.comparison.filters?.length > 0;
return (
<div>
{tct(
'Percentage of sessions affected by an issue is more than [value] [interval] [where]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.interval
)?.label || condition.comparison.interval,
where: hasSubfilters ? t('where') : null,
}
)}
{hasSubfilters && (
<SubfilterDetailsList subfilters={condition.comparison.filters} />
)}
</div>
);
}

export function PercentSessionsPercentDetails({condition}: {condition: DataCondition}) {
return tct(
'Percentage of sessions affected by an issue is [value]% higher [interval] compared to [comparison_interval]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(choice => choice.value === condition.comparison.interval)
?.label || condition.comparison.interval,
comparison_interval:
COMPARISON_INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.comparison_interval
)?.label || condition.comparison.comparison_interval,
}
const hasSubfilters = condition.comparison.filters?.length > 0;
return (
<div>
{tct(
'Percentage of sessions affected by an issue is [value]% higher [interval] compared to [comparison_interval] [where]',
{
value: condition.comparison.value,
interval:
INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.interval
)?.label || condition.comparison.interval,
comparison_interval:
COMPARISON_INTERVAL_CHOICES.find(
choice => choice.value === condition.comparison.comparison_interval
)?.label || condition.comparison.comparison_interval,
where: hasSubfilters ? t('where') : null,
}
)}
{hasSubfilters && (
<SubfilterDetailsList subfilters={condition.comparison.filters} />
)}
</div>
);
}

export function PercentSessionsNode() {
return tct('Percentage of sessions affected by an issue is [select]', {
select: <ComparisonTypeField />,
});
const {condition} = useDataConditionNodeContext();
const hasSubfilters = condition.comparison.filters?.length > 0;
return (
<div>
<RowLine>
{tct('Percentage of sessions affected by an issue is [select] [where]', {
select: <ComparisonTypeField />,
where: hasSubfilters ? <ConditionBadge>{t('Where')}</ConditionBadge> : null,
})}
</RowLine>
<SubfiltersList />
</div>
);
}

function ComparisonTypeField() {
Expand Down
Loading