Skip to content

chore(detectors): Add google API filtering for Consecutive HTTP detector #94634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

chore(detectors): Add google API filtering for Consecutive HTTP detector #94634

merged 2 commits into from
Jun 30, 2025

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Jun 30, 2025 •
edited
Loading

this pr updates the eligible span method to look for googleapis.com in the description. one example of this would be their ai platform which has aiplatform.googleapis.com in the description.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 30, 2025
@roggenkemper roggenkemper marked this pull request as ready for review June 30, 2025 19:50
@roggenkemper roggenkemper requested review from a team as code owners June 30, 2025 19:50
@roggenkemper roggenkemper changed the title chore(detectors): Add Vertex url to filtering for Consecutive HTTP detector chore(detectors): Add google API filtering for Consecutive HTTP detector Jun 30, 2025
mrduncan
mrduncan approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@mrduncan mrduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this note, we should probably also add AWS/Azure if they use unique domains for these which aren't reused elsewhere

@roggenkemper roggenkemper merged commit 7c00178 into master Jun 30, 2025
66 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/httpvertex branch June 30, 2025 20:39
@roggenkemper roggenkemper mentioned this pull request Jun 30, 2025
Draft
andrewshie-sentry pushed a commit that referenced this pull request Jul 14, 2025
@roggenkemper @andrewshie-sentry
chore(detectors): Add google API filtering for Consecutive HTTP detec…
2ac8469 
…tor (#94634)

this pr updates the eligible span method to look for `googleapis.com` in
the description. one example of this would be their ai platform which
has `aiplatform.googleapis.com` in the description.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrduncan mrduncan mrduncan approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roggenkemper @mrduncan