-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(feedback): enable feedback category option for org stats page #94649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
static/app/types/core.tsx
Outdated
LOG_BYTE = 'logByte', | ||
SEER_AUTOFIX = 'seerAutofix', | ||
SEER_SCANNER = 'seerScanner', | ||
USER_REPORT_V2 = 'user_report_v2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in the same format as the others (camel case singular). Does changing this to that format break stats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I thought from the comment that it's supposed to match the relay enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh i totally missed that, then that means all the others in camel case need to be changed 😭 not your problem though, thanks for pointing out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha thanks, think it should be feedback
actually based on https://github.com/getsentry/relay/blob/e4ba401fba6028036f251685d77b7263e61310d3/relay-base-schema/src/data_category.rs#L192
static/app/types/core.tsx
Outdated
LOG_BYTE = 'logByte', | ||
SEER_AUTOFIX = 'seerAutofix', | ||
SEER_SCANNER = 'seerScanner', | ||
USER_REPORT_V2 = 'user_report_v2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh i totally missed that, then that means all the others in camel case need to be changed 😭 not your problem though, thanks for pointing out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Enum Naming Inconsistency
The USER_REPORT_V2
entry uses the same value 'feedback'
in both DataCategory
and DataCategoryExact
enums. This breaks the established naming convention where DataCategory
values are plural (e.g., errors
, transactions
) and DataCategoryExact
values are singular (e.g., error
, transaction
). The DataCategory
value should be plural (e.g., 'feedbacks'
) to maintain consistency and prevent issues in code relying on this distinction.
static/app/types/core.tsx#L95-L127
sentry/static/app/types/core.tsx
Lines 95 to 127 in b91f2a5
SEER_SCANNER = 'seerScanner', | |
USER_REPORT_V2 = 'feedback', | |
} | |
/** | |
* https://github.com/getsentry/relay/blob/master/relay-base-schema/src/data_category.rs | |
* Matches the backend singular backend enum directly. | |
* For display variations, refer to `DATA_CATEGORY_INFO` rather than manipulating these strings | |
*/ | |
export enum DataCategoryExact { | |
ERROR = 'error', | |
TRANSACTION = 'transaction', | |
ATTACHMENT = 'attachment', | |
PROFILE = 'profile', | |
PROFILE_INDEXED = 'profileIndexed', | |
REPLAY = 'replay', | |
// TODO: Update processed and indexed transactions to camel case" | |
TRANSACTION_PROCESSED = 'transaction_processed', | |
TRANSACTION_INDEXED = 'transaction_indexed', | |
MONITOR = 'monitor', | |
MONITOR_SEAT = 'monitorSeat', | |
PROFILE_DURATION = 'profileDuration', | |
PROFILE_DURATION_UI = 'profileDurationUI', | |
PROFILE_CHUNK = 'profileChunk', | |
PROFILE_CHUNK_UI = 'profileChunkUI', | |
SPAN = 'span', | |
SPAN_INDEXED = 'spanIndexed', | |
UPTIME = 'uptime', | |
LOG_ITEM = 'logItem', | |
LOG_BYTE = 'logByte', | |
SEER_AUTOFIX = 'seerAutofix', | |
SEER_SCANNER = 'seerScanner', | |
USER_REPORT_V2 = 'feedback', |
Was this report helpful? Give feedback by reacting with 👍 or 👎
…94649) Part of https://linear.app/getsentry/project/user-feedback-abuse-quotas-05cbd47d06cf/overview Adds the option to see feedback usage in `/settings/stats`. We're already emitting accepted, invalid, and rate limited outcomes. Example from my test project:  The category is named `user_report_v2` in Relay, but api name for the stats endpoint is feedback, product name User Feedback. Seems there's no backend changes needed for the query.
Part of https://linear.app/getsentry/project/user-feedback-abuse-quotas-05cbd47d06cf/overview
Adds the option to see feedback usage in

/settings/stats
. We're already emitting accepted, invalid, and rate limited outcomes. Example from my test project:The category is named
user_report_v2
in Relay, but api name for the stats endpoint is feedback, product name User Feedback. Seems there's no backend changes needed for the query.