fix(Jira-Server): Adds halts, better exceptions for failed syncs #95281
Conversation
github-actions
bot
added
the
Scope: Backend
| def test_syncs_outbound_assignee(self, mock_sync_assignee, mock_record_event): | ||
| external_issue = self.create_integration_external_issue( | ||
| # Create a shared external issue for most tests | ||
| self.external_issue = self.create_integration_external_issue( |
There was a problem hiding this comment.
This was repeated in nearly every single test, so I hoisted it into the setup instead.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95281 +/- ##
==========================================
+ Coverage 86.56% 87.86% +1.29%
==========================================
Files 10458 10468 +10
Lines 604876 605539 +663
Branches 23617 23617
==========================================
+ Hits 523625 532055 +8430
+ Misses 80890 73123 -7767
Partials 361 361 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| ) | ||
|
|
||
| if jira_user is None: | ||
| # TODO(jess): do we want to email people about these types of failures? |
There was a problem hiding this comment.
| # TODO(jess): do we want to email people about these types of failures? |
There was a problem hiding this comment.
I'm leaving it as a vestigial reminder to do this in the future 😅 We do want this eventually.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Adds distinct error handling for different assignment failures:
Also renames the logs generated by Jira Server, since these are currently identical to the Jira SaaS logs, making it difficult to differentiate between the two when triaging failures.