ref(issues): improve similar issues stacktrace diff #97645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
shayna-ch
force-pushed
the
shayna-ch/improve-similar-issues-diff-8
branch
from
5b4d319 to
8310f11
Compare
scttcper
reviewed
Aug 14, 2025
static/app/components/splitDiff.tsx
Outdated
Comment on lines
70
to
86
| ? (() => { | ||
| const leftText = line.reduce( | ||
| (acc, result) => (result.added ? acc : acc + result.value), | ||
| '' | ||
| ); | ||
| const rightText = line.reduce( | ||
| (acc, result) => (result.removed ? acc : acc + result.value), | ||
| '' | ||
| ); | ||
|
|
||
| // Handle edge cases where text might be empty | ||
| if (!leftText && !rightText) { | ||
| return line; // Return original line if both texts are empty | ||
| } | ||
|
|
||
| return diffWords(leftText, rightText); | ||
| })() |
There was a problem hiding this comment.
don't use iife, make a small named function somewhere
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scttcper
approved these changes
Aug 14, 2025
static/app/components/splitDiff.tsx
Outdated
Comment on lines
58
to
82
| const processResults = (): Change[][] => { | ||
| let currentLine: Change[] = []; | ||
| const processedLines: Change[][] = []; | ||
| for (const change of results) { | ||
| const lines = change.value.split('\n'); | ||
| for (let i = 0; i < lines.length; i++) { | ||
| const lineValue = lines[i]; | ||
| if (lineValue !== undefined && lineValue !== '') { | ||
| currentLine.push({ | ||
| value: lineValue, | ||
| added: change.added, | ||
| removed: change.removed, | ||
| }); | ||
| } | ||
| if (i < lines.length - 1) { | ||
| processedLines.push(currentLine); | ||
| currentLine = []; | ||
| } | ||
| } | ||
| } | ||
| if (currentLine.length > 0) { | ||
| processedLines.push(currentLine); | ||
| } | ||
| return processedLines; | ||
| }; |
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve similar issues stacktrace diff by changing diff
typetolines, and then diffing those lines byword.Before/After
Change to
linesThe diff library does not know how to split stacktraces into words effectively, leading to weird formatting like file names and function calls being split up.
Changing the diff type to
linespreserves the structure of the stack trace when diffing. Then, diffing those split lines bywordskeeps the structure made withlinesbut gives a more accurate diff.processChangediffFn()returns a list ofChangeobjects whos values have to be put back together to form the stack trace in the UI. To preserve formatting, each change has to only contain one line, or you get multi line highlights like this.Additionally, including newlines can cause spacing issues(below) in the
<SplitBody>component so generally they are removed, and lines are broken up instead by the<Line>component.