-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(replay): Add a dropdown to make it easier to select replays inside stories #97713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6b72dd
to
8b0a017
Compare
ada672d
to
78aad42
Compare
billyvg
approved these changes
Aug 15, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
…de stories (#97713) Now we can pick replays instead of having to go copy+paste the replayId from the product. Checkout the example at `/stories/?name=app%2Fcomponents%2Freplays%2Fplayer%2FreplayPlayer.stories.tsx` <img width="869" height="537" alt="SCR-20250812-mhxi" src="https://github.com/user-attachments/assets/c409b586-d6cf-4ea4-98a3-1c4ddf224574" /> A little meta too, because there's a story for the list of replays which is used in stories. | Inline on page | In a Hovercard | | --- | --- | | <img width="482" height="644" alt="Screenshot 2025-08-12 at 1 44 39 PM" src="https://github.com/user-attachments/assets/6d3b9393-1294-4c59-a9c3-2f604a4b3e6d" /> | <img width="319" height="624" alt="SCR-20250812-mgxp" src="https://github.com/user-attachments/assets/5c715ac1-6f61-4ba5-95af-aa3525e3e69d" /> | This is also something that could be helpful in the product in the future, maybe.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
…de stories (#97713) Now we can pick replays instead of having to go copy+paste the replayId from the product. Checkout the example at `/stories/?name=app%2Fcomponents%2Freplays%2Fplayer%2FreplayPlayer.stories.tsx` <img width="869" height="537" alt="SCR-20250812-mhxi" src="https://github.com/user-attachments/assets/c409b586-d6cf-4ea4-98a3-1c4ddf224574" /> A little meta too, because there's a story for the list of replays which is used in stories. | Inline on page | In a Hovercard | | --- | --- | | <img width="482" height="644" alt="Screenshot 2025-08-12 at 1 44 39 PM" src="https://github.com/user-attachments/assets/6d3b9393-1294-4c59-a9c3-2f604a4b3e6d" /> | <img width="319" height="624" alt="SCR-20250812-mgxp" src="https://github.com/user-attachments/assets/5c715ac1-6f61-4ba5-95af-aa3525e3e69d" /> | This is also something that could be helpful in the product in the future, maybe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can pick replays instead of having to go copy+paste the replayId from the product.

Checkout the example at
/stories/?name=app%2Fcomponents%2Freplays%2Fplayer%2FreplayPlayer.stories.tsx
A little meta too, because there's a story for the list of replays which is used in stories.
This is also something that could be helpful in the product in the future, maybe.