fix(aci): Make rule/workflow redis buffer interactions non-transactional #97917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
NB: technically, we should be able to make single key operations transactional, but it'd require us to change redis client libraries. We should, but I don't think we need to block on it. |
cathteng
approved these changes
Aug 15, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
…nal (#97917) Clustered redis doesn't support transactional pipelines, which are the default in the Buffer code. However, we aren't too reliant on the transactionality; in most cases, we're performing single operations and adding an expiry. We don't rely on expiry for key removal, and remove or clear them explicitly. The main multi-key cases where this might have impact are cases in which partial keysets are arguably more correct than no key at all. We still need to be careful, but on the whole, this seems safe and is necessary to move to a standard cluster.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
…nal (#97917) Clustered redis doesn't support transactional pipelines, which are the default in the Buffer code. However, we aren't too reliant on the transactionality; in most cases, we're performing single operations and adding an expiry. We don't rely on expiry for key removal, and remove or clear them explicitly. The main multi-key cases where this might have impact are cases in which partial keysets are arguably more correct than no key at all. We still need to be careful, but on the whole, this seems safe and is necessary to move to a standard cluster.
constantinius
pushed a commit
that referenced
this pull request
Sep 1, 2025
…nal (#97917) Clustered redis doesn't support transactional pipelines, which are the default in the Buffer code. However, we aren't too reliant on the transactionality; in most cases, we're performing single operations and adding an expiry. We don't rely on expiry for key removal, and remove or clear them explicitly. The main multi-key cases where this might have impact are cases in which partial keysets are arguably more correct than no key at all. We still need to be careful, but on the whole, this seems safe and is necessary to move to a standard cluster.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clustered redis doesn't support transactional pipelines, which are the default in the Buffer code.
However, we aren't too reliant on the transactionality; in most cases, we're performing single operations and adding an expiry. We don't rely on expiry for key removal, and remove or clear them explicitly.
The main multi-key cases where this might have impact are cases in which partial keysets are arguably more correct than no key at all.
We still need to be careful, but on the whole, this seems safe and is necessary to move to a standard cluster.