feat(on-demand): Add feature flag check before cardinality check #98726
Conversation
github-actions
bot
added
the
Scope: Backend
| is_task: bool = False, | ||
| widget_query: DashboardWidgetQuery | None = None, | ||
| ) -> dict[str, str]: | ||
| if not features.has("organizations:on-demand-metrics-extraction-widgets", organization): |
There was a problem hiding this comment.
@k-fish would you be able to advise if this is okay for us to do? I suppose when we migrate fully to EAP then we can get rid of this, but in an effort to make some easy progress for other users, I figured we could just feature flag this check
It seems like we wanted to evaluate it even without the feature flag so when we rolled out, people's queries were good to go
There was a problem hiding this comment.
We can get rid of the flag if we confirm if any of the orgs are not still on am1 / their widgets work on EAP
In theory yes, we were supposed to check so that we could roll it out for every org, but am3 came along. We're okay skipping it for extraction widgets.
Can you copy the test with the flag to assert the old behaviour? otherwise it's fine I think
| is_task: bool = False, | ||
| widget_query: DashboardWidgetQuery | None = None, | ||
| ) -> dict[str, str]: | ||
| if not features.has("organizations:on-demand-metrics-extraction-widgets", organization): |
There was a problem hiding this comment.
We can get rid of the flag if we confirm if any of the orgs are not still on am1 / their widgets work on EAP
In theory yes, we were supposed to check so that we could roll it out for every org, but am3 came along. We're okay skipping it for extraction widgets.
Can you copy the test with the flag to assert the old behaviour? otherwise it's fine I think
narsaynorath
deleted the
nar/feat/dashboards-feature-flag-cardinality-check
branch
Some users are experiencing high latency due to this cardinality check. Since metrics extraction for widgets has paused and we're in the process of migrating users to spans/EAP, I figured we could avoid running this check for users that do not have the feature flag if we're not planning to continue rolling it out.
e.g. this trace shows 15s waiting for the cardinality check for an org that doesn't have access