Skip to content

Conversation

kcons
Copy link
Member

@kcons kcons commented Sep 13, 2025

For process_workflows_event, querying for Group is one of the primary required queries.
It's frequently very fast (~1ms), but at times we've observed it taking 100ms or more. Perhaps more significantly, querying for Group by ID is the most common query the app does, and we're part of htat.
Given that this task runs after post_process, which does read Group through the cache, the Group we're processing should nearly always be in the cache, so here we expect a very high hit rate, a significant reduction in query volume to the database, and improvement in some of our wost case task latency.

@kcons kcons requested a review from a team as a code owner September 13, 2025 00:33
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 13, 2025
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/workflow_engine/tasks/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #99449      +/-   ##
==========================================
- Coverage   81.21%   81.21%   -0.01%     
==========================================
  Files        8584     8584              
  Lines      380140   380140              
  Branches    24106    24106              
==========================================
- Hits       308734   308733       -1     
- Misses      71060    71061       +1     
  Partials      346      346              

@kcons kcons enabled auto-merge (squash) September 15, 2025 14:52
@kcons kcons merged commit 464c28b into master Sep 15, 2025
65 checks passed
@kcons kcons deleted the kcons/cachegroup branch September 15, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants