Skip to content

ref(ingest): Remove celery healthchecks entirely #99667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

ref(ingest): Remove celery healthchecks entirely #99667

merged 1 commit into from
Sep 18, 2025

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Sep 17, 2025 •
edited
Loading

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2025
@untitaker untitaker marked this pull request as ready for review September 17, 2025 12:35
@untitaker untitaker merged commit bde4e2b into master Sep 18, 2025
66 checks passed
@untitaker untitaker deleted the celery-backpressure branch September 18, 2025 08:02
@untitaker untitaker added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Sep 18, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 1c07e9c

getsentry-bot added a commit that referenced this pull request Sep 18, 2025
@getsentry-bot @untitaker
Revert "ref(ingest): Remove celery healthchecks entirely (#99667)"
1c07e9c 
This reverts commit bde4e2b.

Co-authored-by: untitaker <[email protected]>
untitaker added a commit that referenced this pull request Sep 18, 2025
@untitaker
Reapply "ref(ingest): Remove celery healthchecks entirely (#99667)"
12921ba 
This reverts commit 1c07e9c.
@untitaker untitaker mentioned this pull request Sep 18, 2025
Merged
@untitaker
Copy link
Member Author 

  File "sentry/runner/commands/run.py", line 747, in backpressure_monitor
    start_service_monitoring()
  File "sentry/processing/backpressure/monitor.py", line 115, in start_service_monitoring
    unhealthy_services = check_service_health(services)
  File "sentry/processing/backpressure/monitor.py", line 66, in check_service_health
    high_watermark = options.get(f"backpressure.high_watermarks.{name}")
  File "sentry/options/manager.py", line 296, in get
    opt = self.lookup_key(key)
  File "sentry/options/manager.py", line 234, in lookup_key
    raise UnknownOption(key)
UnknownOption: 'backpressure.high_watermarks.celery'

untitaker added a commit that referenced this pull request Sep 18, 2025
@untitaker
Reapply "ref(ingest): Remove celery healthchecks entirely #99667" (#9…
c816613 
…9787)

- **Reapply "ref(ingest): Remove celery healthchecks entirely
(#99667)"**
- **skip unknown services**
@untitaker untitaker mentioned this pull request Sep 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory approved these changes

@evanh evanh evanh approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@untitaker @getsentry-bot @markstory @evanh