Skip to content

ggml : add Q8_0 quantization format (rename the old one to Q8_1) (ARM NEON) #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 25, 2023
Merged

ggml : add Q8_0 quantization format (rename the old one to Q8_1) (ARM NEON) #1179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f83c321
ggml : add Q8_0 quantization format (rename the old one to Q8_1)
ggerganov Apr 25, 2023
79cfdf5
tests : fix test-quantize-fns
ggerganov Apr 25, 2023
d8bf720
ggml : finalize Q8_0 implementation
ggerganov Apr 25, 2023
6496b79
ggml : use q4_0_q8_0 and q4_2_q8_0
ggerganov Apr 25, 2023
88618ab
ggml : fix Q8_0 dot product bug (ARM)
ggerganov Apr 25, 2023
6e0f0b6
ggml : Q8_0 unroll x2
ggerganov Apr 25, 2023
46fc696
ggml : fix bug - using wrong block type
ggerganov Apr 25, 2023
91bfa51
ggml : extend quantize_fns_t with "vec_dot_type"
ggerganov Apr 25, 2023
4ddb983
ggml : fix Q8_0 to use 255 values out of 256
ggerganov Apr 25, 2023
e8c3731
ggml : fix assert using wrong QK4_2 instead of QK4_3
ggerganov Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ggml : fix Q8_0 to use 255 values out of 256
  • Loading branch information
@ggerganov
ggerganov committed Apr 25, 2023
commit 4ddb983a02699ce530d63cc0beef404928cab0e0
10 changes: 3 additions & 7 deletions ggml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,25 +1295,21 @@ static void quantize_row_q8_0_reference(const float * restrict x, block_q8_0 * r

for (int i = 0; i < nb; i++) {
float amax = 0.0f; // absolute max
float max = 0.0f;

for (int l = 0; l < QK8_0; l++) {
const float v = x[i*QK8_0 + l];
if (amax < fabsf(v)) {
amax = fabsf(v);
max = v;
}
amax = MAX(amax, fabsf(v));
}

const float d = max / -128;
const float d = amax / ((1 << 7) - 1);
const float id = d ? 1.0f/d : 0.0f;

y[i].d = d;

for (int l = 0; l < QK8_0; ++l) {
const float v0 = x[i*QK8_0 + l]*id;

y[i].qs[l] = MIN(127, roundf(v0));
y[i].qs[l] = roundf(v0);
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions tests/test-quantize-fns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ float dot_product_error(quantize_fns_t & qfns, size_t test_size, const float * t
std::vector<uint8_t> tmp_q1(2*test_size);
std::vector<uint8_t> tmp_q2(2*test_size);

qfns.quantize_row_q(test_data1, tmp_q1.data(), test_size);
qfns.quantize_row_q (test_data1, tmp_q1.data(), test_size);
qfns.quantize_row_q_dot(test_data2, tmp_q2.data(), test_size);

float result = INFINITY;
Expand Down Expand Up @@ -125,7 +125,7 @@ int main(int argc, char * argv[]) {
failed = !(total_error < MAX_QUANTIZATION_TOTAL_ERROR);
num_failed += failed;
if (failed || verbose) {
printf("%5s absolute quantization error: %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], total_error);
printf("%5s absolute quantization error: %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], total_error);
}

const float reference_error = reference_quantization_error(qfns, test_size, test_data.data());
Expand All @@ -139,7 +139,7 @@ int main(int argc, char * argv[]) {
failed = !(vec_dot_error < MAX_DOT_PRODUCT_ERROR);
num_failed += failed;
if (failed || verbose) {
printf("%5s dot product error: %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], vec_dot_error);
printf("%5s dot product error: %s (%f)\n", ggml_type_name(type), RESULT_STR[failed], vec_dot_error);
}
}
}
Expand Down