Skip to content

llama: remove init f16 tables #17511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tosone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

llama: remove init f16 tables #17511

tosone wants to merge 1 commit into from
+0 −7

Conversation

@tosone
Copy link

@tosone tosone commented Nov 26, 2025

It seems there's no need to initialize the f16 tables.

@tosone tosone requested a review from ggerganov as a code owner November 26, 2025 02:34
@taronaeo
Copy link
Collaborator

taronaeo commented Nov 26, 2025

@slaren I remember removing these few lines broke something when we refactored GGML_CPU_FP*_TO_FP* right?

@taronaeo
Copy link
Collaborator

taronaeo commented Nov 26, 2025

Not sure if this is the same, but this is what I'm referring to: 8efdc0b from #14317

@taronaeo taronaeo requested a review from slaren November 26, 2025 02:42
@loci-dev loci-dev mentioned this pull request Nov 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov Awaiting requested review from ggerganov ggerganov is a code owner

@slaren slaren Awaiting requested review from slaren

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tosone @taronaeo @slaren