ggml : remove GGML_KQ_MASK_PAD constant #17910
Merged
+19
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CISC
approved these changes
Dec 10, 2025
jeffbolznv
reviewed
Dec 10, 2025
ggml/include/ggml.h
Outdated
|
|
||
| // q: [n_embd_k, n_batch, n_head, ne3 ] | ||
| // k: [n_embd_k, n_kv, n_head_kv, ne3 ] | ||
| // v: [n_embd_v, n_kv, n_head_kv, ne3 ] !! not transposed !! |
Collaborator
There was a problem hiding this comment.
There's a use of GGML_KQ_MASK_PAD in the comment on the next line.
ngxson
approved these changes
Dec 10, 2025
jeffbolznv
approved these changes
Dec 10, 2025
github-actions
bot
added
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cont #16309
Simplify code now that we no longer need to pad the KQ mask for flash attention.