Make LlamaData utility functions static in llama-run
#17913
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description of the problem** Class `LlamaData` in `llama-run` contains utility functions that never access non-static data members or non-static member functions. However they are unnecessarily defined as non-static as well. **Proposed solution** Make those utility functions static, so there is single copy of them shared by all objects of that class type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Class
LlamaDatainllama-runcontains utility functions that never access non-static data members or non-static member functions. However they are unnecessarily defined as non-static as well.Proposed solution
Make those utility functions static, so there is single copy of them shared by all objects of that class type.