Restore clip's cb() to its rightful glory - extract common debugging elements in llama #17914
Conversation
tools/mtmd/clip.cpp
Outdated
| std::string t_name = std::string(name) + "_" + std::to_string(il); | ||
| ggml_tensor * args[] = { t }; | ||
| ggml_tensor * res = ggml_custom_4d(ctx0, t->type, t->ne[0], t->ne[1], t->ne[2], t->ne[3], args, 1, print_debug, 1, nullptr); | ||
| strcpy(res->name, t_name.c_str()); |
There was a problem hiding this comment.
Or even better, ggml_format_name
tools/mtmd/clip.cpp
Outdated
| ggml_tensor * args[] = { t }; | ||
| ggml_tensor * res = ggml_custom_4d(ctx0, t->type, t->ne[0], t->ne[1], t->ne[2], t->ne[3], args, 1, print_debug, 1, nullptr); | ||
| strcpy(res->name, t_name.c_str()); | ||
| ggml_build_forward_expand(gf, res); |
There was a problem hiding this comment.
I think we should guard the whole thing under ctx->debug_graph. seems like it's got removed by mistake?
tools/mtmd/clip.cpp
Outdated
| #include "ggml-cpp.h" | ||
| #include "ggml-alloc.h" | ||
| #include "ggml-backend.h" | ||
| #include "ggml/src/ggml-impl.h" |
There was a problem hiding this comment.
This should be removed - we cannot include internal header from ggml
tools/mtmd/clip.cpp
Outdated
| #include <cstring> | ||
| #include <fstream> | ||
| #include <map> | ||
| #include <memory> |
There was a problem hiding this comment.
some of these are already included by clip-impl.h - do we really need to include them again here?
…D_DEBUG_GRAPH with same functionality
|
All right, based on the convo with @ngxson I've decided to tackle this properly:
|
|
I would very much like to extend the callback procedure to (a) make it also possible in other clients (such as |
pwilkin
changed the title
There was a problem hiding this comment.
I think this should be inside common/debug.h instead. There is no internal libllama components using these functions
2 participants
I used my callback function from my Qwen3Next testing days, it seems like it works more cleanly than the previous one which was causing some problems with the scheduler / buffers.