Skip to content

llava : fix tokenization to not add bos after system prompt #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2023
Merged

llava : fix tokenization to not add bos after system prompt #3645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0fb74c
llava : fix tokenization to not add bos after system prompt
ggerganov Oct 16, 2023
20131fe
set seed
monatis Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
set seed
  • Loading branch information
@monatis
monatis committed Oct 16, 2023
commit 20131fef6d4fae60a491bbac757d4c79cc247cfa
1 change: 1 addition & 0 deletions examples/llava/llava.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ int main(int argc, char ** argv) {
ctx_params.n_ctx = params.n_ctx < 2048 ? 2048 : params.n_ctx; // we need a longer context size to process image embeddings
ctx_params.n_threads = params.n_threads;
ctx_params.n_threads_batch = params.n_threads_batch == -1 ? params.n_threads : params.n_threads_batch;
ctx_params.seed = params.seed;

llama_context * ctx_llama = llama_new_context_with_model(model, ctx_params);

Expand Down