Skip to content

tests : disable system() calls#6198

Merged
ggerganov merged 1 commit into
masterfrom
gg/disable-system-calls
Mar 21, 2024
Merged

tests : disable system() calls#6198
ggerganov merged 1 commit into
masterfrom
gg/disable-system-calls

Conversation

@ggerganov
Copy link
Copy Markdown
Member

python and node are not always present - need to figure out a better way to run these tests

@ggerganov ggerganov merged commit 924ce1d into master Mar 21, 2024
@ggerganov ggerganov deleted the gg/disable-system-calls branch March 21, 2024 14:20
@ggerganov
Copy link
Copy Markdown
Member Author

cc @ochafik

@cebtenzzre
Copy link
Copy Markdown
Collaborator

It should be simple enough to check if std::system("python --version") and std::system("node --version") succeed before running their respective tests, and emit a warning otherwise.

ochafik pushed a commit to ochafik/llama.cpp that referenced this pull request Mar 21, 2024
@ochafik
Copy link
Copy Markdown
Collaborator

ochafik commented Mar 21, 2024

Sorry about the breakage and thx for the suggestion ( → drafted #6207 )

ggerganov pushed a commit that referenced this pull request Mar 22, 2024
* json: only attempt python & node schema conversion tests if their bins are present

Tests introduced in #5978
disabled in #6198

* json: orange warnings when tests skipped

* json: ensure py/js schema conv tested on ubuntu-focal-make

* json: print env vars in test
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
* json: only attempt python & node schema conversion tests if their bins are present

Tests introduced in ggml-org#5978
disabled in ggml-org#6198

* json: orange warnings when tests skipped

* json: ensure py/js schema conv tested on ubuntu-focal-make

* json: print env vars in test
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* json: only attempt python & node schema conversion tests if their bins are present

Tests introduced in ggml-org#5978
disabled in ggml-org#6198

* json: orange warnings when tests skipped

* json: ensure py/js schema conv tested on ubuntu-focal-make

* json: print env vars in test
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* json: only attempt python & node schema conversion tests if their bins are present

Tests introduced in ggml-org#5978
disabled in ggml-org#6198

* json: orange warnings when tests skipped

* json: ensure py/js schema conv tested on ubuntu-focal-make

* json: print env vars in test
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* json: only attempt python & node schema conversion tests if their bins are present

Tests introduced in ggml-org#5978
disabled in ggml-org#6198

* json: orange warnings when tests skipped

* json: ensure py/js schema conv tested on ubuntu-focal-make

* json: print env vars in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants