Skip to content

Conversation

@ggwpez
Copy link
Owner

@ggwpez ggwpez commented May 14, 2023

Closes #3

Changes:

  • Add FormattedWarning. It is possible to directly instantiate this enum, or use new_deprecated(name, note, span). The builder pattern is not used, since there are only three fields and none are optional.
  • 🚨 Remove Warning::new_raw as Warning became an enum and can directly be constructed. This is more in line when adding more warning types later.
  • Move crate to workspace and add UI tests.
  • Update docs.
Automatic API diff

cargo public-api -p proc-macro-warning --omit auto-derived-impls --omit auto-trait-impls --omit blanket-impls diff latest

Removed items from the public API
=================================
-pub struct proc_macro_warning::Warning
-pub proc_macro_warning::Warning::index: core::option::Option<usize>
-pub proc_macro_warning::Warning::links: alloc::vec::Vec<alloc::string::String>
-pub proc_macro_warning::Warning::message: alloc::string::String
-pub proc_macro_warning::Warning::name: alloc::string::String
-pub proc_macro_warning::Warning::span: proc_macro2::Span
-pub fn proc_macro_warning::Warning::new_raw(name: alloc::string::String, index: core::option::Option<usize>, message: alloc::string::String, help_links: alloc::vec::Vec<alloc::string::String>, span: proc_macro2::Span) -> proc_macro_warning::Warning

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
+pub enum proc_macro_warning::FormattedWarning
+pub proc_macro_warning::FormattedWarning::Deprecated
+pub proc_macro_warning::FormattedWarning::Deprecated::name: proc_macro2::Ident
+pub proc_macro_warning::FormattedWarning::Deprecated::note: alloc::string::String
+pub proc_macro_warning::FormattedWarning::Deprecated::span: core::option::Option<proc_macro2::Span>
+impl proc_macro_warning::FormattedWarning
+pub fn proc_macro_warning::FormattedWarning::new_deprecated<'a, S, T>(name: S, note: T, span: proc_macro2::Span) -> Self where S: core::convert::Into<&'a str>, T: core::convert::Into<alloc::string::String>
+impl core::convert::Into<proc_macro_warning::FormattedWarning> for proc_macro_warning::Warning
+impl core::convert::Into<proc_macro_warning::FormattedWarning> for proc_macro_warning::Warning
+pub fn proc_macro_warning::FormattedWarning::into(self) -> proc_macro_warning::FormattedWarning
+impl quote::to_tokens::ToTokens for proc_macro_warning::FormattedWarning
+pub fn proc_macro_warning::FormattedWarning::to_tokens(&self, stream: &mut proc_macro2::TokenStream)
+pub enum proc_macro_warning::Warning
+pub proc_macro_warning::Warning::Deprecated
+pub proc_macro_warning::Warning::Deprecated::index: core::option::Option<usize>
+pub proc_macro_warning::Warning::Deprecated::links: alloc::vec::Vec<alloc::string::String>
+pub proc_macro_warning::Warning::Deprecated::message: alloc::string::String
+pub proc_macro_warning::Warning::Deprecated::name: alloc::string::String
+pub proc_macro_warning::Warning::Deprecated::span: proc_macro2::Span
+pub fn proc_macro_warning::Warning::into(self) -> proc_macro_warning::FormattedWarning

ggwpez and others added 9 commits May 6, 2023 09:39
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez merged commit c68eb26 into master May 14, 2023
@ggwpez ggwpez deleted the dev branch May 14, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be less opinionated about the deprecation warning

2 participants