This repository was archived by the owner on Jul 1, 2020. It is now read-only.
fixed removeFromValidationSummary to also remove from 'local' array #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from master
before this a validationSummary entry would reappear on "go back" in wizard.
Owner
|
Oh yes sorry, this function was introduced by you and I forgot to do any check on it ;) |
ghiscoding
added a commit
that referenced
this pull request
Apr 9, 2015
fixed removeFromValidationSummary to also remove from 'local' array
Contributor
Author
|
:) |
Owner
|
Alright I just finished bumping the version to 1.3.16, time to go to work now... Thanks for the help ;) |
Contributor
Author
|
The thanks are all yours :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your latest change broke the removeFromValidationSummary functionality for me.
I think I've fixed it. (Works for me :) )
Check it out and see if it works as expected.
If you could find a more elegant solution it would me much appreciated :)