git-ecosystem migration: prepare repo #49
Conversation
Certain files in the project currently contain direct references to GitHub ownership. In light of the impending migration to the git-ecosystem org and the subsequent open sourcing of this project, these claims do not apply and are being removed. Signed-off-by: Lessley Dennington <[email protected]>
Update module names to specify `git-ecosystem` as Git Bundle Server's organization. Signed-off-by: Lessley Dennington <[email protected]>
Update Git Bundle Server's bundle id to `git-ecosystem` (based on this guidance [1] indicating that hyphens are acceptable). 1: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleidentifier#discussion Signed-off-by: Lessley Dennington <[email protected]>
ldennington
force-pushed
the
ldennington/migration-prep
branch
from
d373bbe to
824fe37
Compare
There was a problem hiding this comment.
These changes all look good to me! The only thing I was (mildly) worried about was changing the install package name/daemon name, but if someone has the old stuff installed, they can use the old uninstaller script to remove the artifacts before installing the new ones.
Once this is merged, I'll create a v0.1.1 with these updates!
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
These changes look good. I don't understand why our builds are green, though.
| # Git Bundle Server | ||
|
|
||
| [bundle-uris]: https://github.com/git/git/blob/next/Documentation/technical/bundle-uri.txt | ||
| [bundle-uris]: https://git-scm.com/docs/bundle-uri |
There was a problem hiding this comment.
A subtle change, but I like it.
|
|
||
| "github.com/github/git-bundle-server/cmd/utils" | ||
| "github.com/github/git-bundle-server/internal/argparse" | ||
| "github.com/github/git-bundle-server/internal/core" | ||
| "github.com/github/git-bundle-server/internal/log" | ||
| "github.com/git-ecosystem/git-bundle-server/cmd/utils" | ||
| "github.com/git-ecosystem/git-bundle-server/internal/argparse" | ||
| "github.com/git-ecosystem/git-bundle-server/internal/core" | ||
| "github.com/git-ecosystem/git-bundle-server/internal/log" | ||
| ) |
There was a problem hiding this comment.
How are our builds working with this change right now?
There was a problem hiding this comment.
I believe these links are referencing the module name defined in go.mod, which was also updated in the same commit:
It does lead to an interesting question - can you just label your module anything (even the name of a different GitHub repo) and have everything work? I guess, based on this PR, the answer is "yes".
There was a problem hiding this comment.
Ah, this explains it better. Basically, the module name can be used to get a package from an external repo hosted on GitHub. But since all of our references are internal, and no external library is using our packages, everything works fine despite the (currently) non-existent GitHub link.
In general, it looks like renaming won't be a problem unless we make external package available to other projects. That might come up with auth, so I'll add a comment to the relevant issue noting it.
There was a problem hiding this comment.
Ah, that's the trick. Since the local module has this name, the build doesn't need to fetch it from GitHub.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This series makes the necessary updates to the repository to prepare to move it to the
git-ecosystemorganization.The first commit updates the project's documentation to remove incorrect GitHub ownership references. The second updates the project's modules to specify
git-ecosystemas the organization name. The third commit updates the projects bundle id fromcom.github.gitbundleservertocom.git-ecosystem.gitbundleserver(based on this guidance that hyphens are acceptable).