Skip to content

default OAuth redirect URI to http://127.0.0.1 #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

default OAuth redirect URI to http://127.0.0.1 #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
default OAuth redirect URI to http://127.0.0.1
  • Loading branch information
@hickford
hickford committed Oct 23, 2023
commit ee35d7bf763f96db1be078a63dec51d81a6c4c8f
2 changes: 1 addition & 1 deletion docs/generic-oauth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ following values in your Git configuration:

- Client ID
- Client Secret (optional)
- Redirect URL
- Redirect URL (optional, defaults to `http://127.0.0.1`)
- Scopes (optional)
- OAuth Endpoints
- Authorization Endpoint
Expand Down
4 changes: 1 addition & 3 deletions src/shared/Core/GenericOAuthConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ public static bool TryGet(ITrace trace, ISettings settings, Uri remoteUri, out G
}
else
{
trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}");
config = null;
return false;
config.RedirectUri = new Uri("http://127.0.0.1");
}

if (settings.TryGetSetting(
Expand Down