Skip to content

Release GCM 2.5.0 (1) #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Release GCM 2.5.0 (1) #1593

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8baadc
msal: update to latest version 4.60.3
mjcheetham Apr 17, 2024
f9e29ec
avalonia: update Avalonia to 11.0.10
mjcheetham Apr 17, 2024
25f0950
Update MSAL and Avalonia dependencies (#1591)
mjcheetham Apr 17, 2024
eb6cd02
diagnose: avoid poluting stderr stream in Git diagnostic
mjcheetham Apr 17, 2024
8f00c5e
diagnose: avoid poluting stderr stream in Git diagnostic (#1590)
mjcheetham Apr 17, 2024
9a51308
linux: ensure Debian package files are owned by root
mjcheetham Apr 18, 2024
d9ac33c
Merge pull request from GHSA-3c3g-h9rx-f7vq
Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
diagnose: avoid poluting stderr stream in Git diagnostic 
Avoid poluting the standard error stream with a 'fatal' Git error
message during the Git diagnostic run as part of the `diagnose` command.

When checking if we are inside of a Git repo we should be using an
explicit check for `IGit::IsInsideRepository` rather than trying to get
the current repo path and checking for null.
  • Loading branch information
@mjcheetham
mjcheetham committed Apr 17, 2024
commit eb6cd02503faf7a7f273603866170349a949ba8c
11 changes: 9 additions & 2 deletions src/shared/Core/Diagnostics/GitDiagnostic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@ protected override Task<bool> RunInternalAsync(StringBuilder log, IList<string>
log.AppendLine($"Git version is '{gitVersion.OriginalString}'");

log.Append("Locating current repository...");
string thisRepo =CommandContext.Git.GetCurrentRepository();
if (!CommandContext.Git.IsInsideRepository())
{
log.AppendLine("Not inside a Git repository.");
}
else
{
string thisRepo = CommandContext.Git.GetCurrentRepository();
log.AppendLine($"Git repository at '{thisRepo}'");
}
log.AppendLine(" OK");
log.AppendLine(thisRepo is null ? "Not inside a Git repository." : $"Git repository at '{thisRepo}'");

log.Append("Listing all Git configuration...");
ChildProcess configProc = CommandContext.Git.CreateProcess("config --list --show-origin");
Expand Down