Skip to content

Fix the build in Visual Studio #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Fix the build in Visual Studio #1711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4a460b4
Fix build in Visual Studio
dscho Sep 30, 2024
a59af02
Update the InnoSetup dependency to v6.3.1
dscho Sep 30, 2024
c6d28d3
installer: do require Windows 7 SP1 or later
dscho Sep 30, 2024
5441da0
installer: avoid using the deprecated `ParseVersion()` function
dscho Sep 30, 2024
cf935a7
installer: avoid running the `UninstallRun` entry more than once
dscho Sep 30, 2024
a749c92
Update the remaining dependencies
dscho Sep 30, 2024
6f13e76
Properly await `Assert.ThrowsAsync()` calls
dscho Sep 30, 2024
da12fc9
Use `Assert.Fail(message)` as appropriate
dscho Sep 30, 2024
48d06a7
Use preferred `Assert.*` patterns
dscho Sep 30, 2024
8bfe765
Use the `Trace2Exception`
dscho Sep 30, 2024
1a774c1
Replace broken `PlatformFact()` constructs
dscho Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Properly await Assert.ThrowsAsync() calls 
Pointed out by Visual Studio.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
@dscho
dscho committed Sep 30, 2024
commit 6f13e76a2730162dbb2cb33502f979f02aa75e25
8 changes: 4 additions & 4 deletions src/shared/Core.Tests/Authentication/BasicAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ namespace GitCredentialManager.Tests.Authentication
public class BasicAuthenticationTests
{
[Fact]
public void BasicAuthentication_GetCredentials_NullResource_ThrowsException()
public async Task BasicAuthentication_GetCredentials_NullResource_ThrowsException()
{
var context = new TestCommandContext();
var basicAuth = new BasicAuthentication(context);

Assert.ThrowsAsync<ArgumentNullException>(() => basicAuth.GetCredentialsAsync(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => basicAuth.GetCredentialsAsync(null));
}

[Fact]
Expand Down Expand Up @@ -58,7 +58,7 @@ public async Task BasicAuthentication_GetCredentials_NonDesktopSession_Resource_
}

[Fact]
public void BasicAuthentication_GetCredentials_NonDesktopSession_NoTerminalPrompts_ThrowsException()
public async Task BasicAuthentication_GetCredentials_NonDesktopSession_NoTerminalPrompts_ThrowsException()
{
const string testResource = "https://example.com";

Expand All @@ -70,7 +70,7 @@ public void BasicAuthentication_GetCredentials_NonDesktopSession_NoTerminalPromp

var basicAuth = new BasicAuthentication(context);

Assert.ThrowsAsync<InvalidOperationException>(() => basicAuth.GetCredentialsAsync(testResource));
await Assert.ThrowsAsync<InvalidOperationException>(() => basicAuth.GetCredentialsAsync(testResource));
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions src/shared/Core.Tests/HostProviderRegistryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ public void HostProviderRegistry_Register_AutoAuthorityId_ThrowException()
}

[Fact]
public void HostProviderRegistry_GetProvider_NoProviders_ThrowException()
public async Task HostProviderRegistry_GetProvider_NoProviders_ThrowException()
{
var context = new TestCommandContext();
var registry = new HostProviderRegistry(context);
var input = new InputArguments(new Dictionary<string, string>());

Assert.ThrowsAsync<Exception>(() => registry.GetProviderAsync(input));
await Assert.ThrowsAsync<Exception>(() => registry.GetProviderAsync(input));
}

[Fact]
Expand Down