Cut new release#350
Merged
mjcheetham merged 21 commits intoreleasefrom May 17, 2021
Merged
Conversation
Add support for detecting GitHub AE (GHAE) and enabling the OAuth authentication mode with the GitHub provider. https://docs.github.com/en/github-ae@latest/admin/overview/about-github-ae
Add a workaround to a broker bug whereby the account control does not appear when running from an elevated process. AzureAD/microsoft-authentication-library-for-dotnet#2560 The underlying issue is to do with COM and the OS account control not being able to call-back in to the elevated process. The workaround is to set the process COM security to "none" iif we are on Windows 10, the process is elevated, and the user hasn't disabled the broker. It is possible the call to CoInitializeSecurity may fail, as this can only be called once in the lifetime of a process, and must be called before any COM interactions occur. The CLR may perform some COM interop before we even get to the Main method(!) We try our best here and call the CoInitializeSecurity function as soon as we reasonably can in the lifetime of our process.
Add support for OAuth with GitHub AE
Add WAM workaround for elevated processes
Upgrade our MSAL libraries to the latest versions: - MS.ID.Client 4.29.0 -> 4.31.0 - MS.ID.Client.Desktop 4.29.0 -> 4.31.0 - MS.ID.Client.Extensions.Msal 2.18.3 -> 2.18.4 This brings a number of fixes that help us, including: - Fix WAM account picker parenting - Fix WAM exceptions in console apps - Fix encoding of params sent to WAM - WebView2 fallback to WebView1 - Stop writing junk to standard out on Linux syswebview flows
Set the MSAL embedded webview window to "Git Credential Manager" to give some context to the user where this dialog came from.
Add some new WAM docs
Fix documentation links for Windows Broker settings
Rename the `master` branch to `main`, and drop the "beta" moniker for the project now that the other Git credential "manager" helpers have all been fully deprecated.
Update CI for rename of default branch to main (and drop the "beta" moniker)
mjcheetham
requested review from
derrickstolee,
dscho,
jeffhostetler and
ldennington
dscho
approved these changes
May 17, 2021
Contributor
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
Yay! "Out of be-ta, out of be-ta, out of be-ta 🎼🎶🎵"...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: