Skip to content

Conversation

@BigDadBear
Copy link
Member

Copilot AI review requested due to automatic review settings December 8, 2025 16:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated automatic_copilot_code_review_enabled parameter from test data, cleaning up a repository rule parameter that is no longer in use per the referenced issue.

  • Removes obsolete test mock data for a deprecated branch ruleset parameter

@GrantBirki
Copy link
Contributor

@BigDadBear I'm no longer at GitHub so I cannot see the contents of the issue that you linked. I think this PR looks fine though and I'm assuming that this repo setting is no longer used so it can be cleaned up here.

This PR looks fine to merge and since it only alters tests there is no need to cut a new release either. Thanks!

@BigDadBear
Copy link
Member Author

Oh no I didn't even notice this was a public repo! 🙈

Yes, this param was recently removed in favor of a dedicated repo rule. More info can be found here: https://github.blog/changelog/2025-07-18-upcoming-deprecations-and-changes-to-copilot-code-review/#automatic-copilot-code-review-checkbox-easier-to-find-easier-to-use-%e2%9c%85

@GrantBirki
Copy link
Contributor

cc @nobe4 as my dedicated merge buddy ❤️

@BigDadBear
Copy link
Member Author

BigDadBear commented Dec 8, 2025

(ps there's a public docs update coming shortly, I will link it here when it's released)

edit: showing the param removed https://docs.github.com/en/enterprise-cloud@latest/rest/repos/rules?apiVersion=2022-11-28#create-a-repository-ruleset

@nobe4 nobe4 merged commit 952fc5e into main Dec 11, 2025
10 checks passed
@nobe4 nobe4 deleted the bdb-param branch December 11, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants