Skip to content

Prompt customers to upgrade from v1 to v2 #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 5 commits into from
Apr 28, 2022
Merged

Prompt customers to upgrade from v1 to v2 #1045

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0256599
Prompt customers to upgrade from v1 to v2
henrymercer Apr 26, 2022
5227afa
Tweak wording of message
henrymercer Apr 28, 2022
35ef6a2
Move `formatGitHubVersion` into util.test.ts
henrymercer Apr 28, 2022
02083c3
Add a comment to explain why we show the upgrade message on GHES 3.4
henrymercer Apr 28, 2022
2bf00f7
Merge branch 'main' into henrymercer/prompt-v1-to-v2-upgrades
henrymercer Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak wording of message
  • Loading branch information
@henrymercer
henrymercer committed Apr 28, 2022
commit 5227afabbec3d1444d9925a15312eb6b2131e4cb
6 changes: 3 additions & 3 deletions lib/util.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/util.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/util.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/util.test.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/util.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ for (const [
if (shouldReportWarning) {
t.true(
warningSpy.calledOnceWithExactly(
sinon.match("CodeQL Action version 1 will be deprecated")
sinon.match("CodeQL Action v1 will be deprecated")
)
);
} else {
Expand Down
6 changes: 3 additions & 3 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,9 +731,9 @@ export async function checkActionVersion(version: string) {
))
) {
core.warning(
"CodeQL Action version 1 will be deprecated on December 7th, 2022. Please upgrade to " +
"version 2. For more information, see " +
"https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/."
"CodeQL Action v1 will be deprecated on December 7th, 2022. Please upgrade to v2. For " +
"more information, see " +
"https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/"
);
}
}
Expand Down