Skip to content

Surface fatal CLI errors in interpret-results and run-queries #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 8 commits into from
Dec 2, 2022
Merged

Surface fatal CLI errors in interpret-results and run-queries #1407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73e2964
Add new error matcher for fatal error
angelapwen Dec 1, 2022
fba7013
Use error catcher on run queries, db interpret
angelapwen Dec 1, 2022
212a20b
Drop extraneous error logging in analyze
angelapwen Dec 1, 2022
634d1e9
Fix error catcher test
angelapwen Dec 1, 2022
4a3ebb3
Add stub for safeWhich method
angelapwen Dec 1, 2022
695a20b
Update src/codeql.ts
angelapwen Dec 2, 2022
9562842
Stop repressing output in runTool
angelapwen Dec 2, 2022
af42b94
Refactor error catcher logic
angelapwen Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop extraneous error logging in analyze
  • Loading branch information
@angelapwen
angelapwen committed Dec 1, 2022
commit 212a20b25972bbac14f72949e278cab317257976
2 changes: 0 additions & 2 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/analyze-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,6 @@ async function run() {
core.setFailed(error.message);
}

console.log(error);

if (error instanceof CodeQLAnalysisError) {
const stats = { ...error.queriesStatusReport };
await sendStatusReport(
Expand Down Expand Up @@ -391,7 +389,6 @@ async function runWrapper() {
await runPromise;
} catch (error) {
core.setFailed(`analyze action failed: ${error}`);
console.log(error);
}
await checkForTimeout();
}
Expand Down