Skip to content

python-setup: Don't allow Poetry to make venv in project #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RasmusWL merged 4 commits into from
Dec 6, 2022
Merged

python-setup: Don't allow Poetry to make venv in project #1419

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fc528c
python-setup: Don't allow Poetry to make venv in project
RasmusWL Dec 6, 2022
27c1438
python-setup: Apply suggestions from code review
RasmusWL Dec 6, 2022
5566638
Update CHANGELOG.md
RasmusWL Dec 6, 2022
3b0a2f6
python-setup: Update comment with fully qualified configuration name
RasmusWL Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md
  • Loading branch information
@RasmusWL
RasmusWL committed Dec 6, 2022
commit 5566638d56bf082e73162c2765aebe1645c34c79
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [UNRELEASED]

- Add a step that tries to upload a SARIF file for the workflow run when that workflow run fails. This will help better surface failed code scanning workflow runs. [#1393](https://github.com/github/codeql-action/pull/1393)
- Python automatic dependency installation will no longer consider dependecy code installed in venv as user-written, for projects using Poetry that specify `virtualenvs.in-project = true` in their `poetry.toml`. [#1419](https://github.com/github/codeql-action/pull/1419).
Copy link
Contributor

@angelapwen angelapwen Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Python automatic dependency installation will no longer consider dependecy code installed in venv as user-written, for projects using Poetry that specify `virtualenvs.in-project = true` in their `poetry.toml`. [#1419](https://github.com/github/codeql-action/pull/1419).
- Python automatic dependency installation will no longer consider dependency code installed in `venv` as user-written, for projects using Poetry that specify `virtualenvs.in-project = true` in their `poetry.toml`. [#1419](https://github.com/github/codeql-action/pull/1419).

Quick typo suggestion


## 2.1.35 - 01 Dec 2022

Expand Down