Skip to content

Set up the Swift version the extractor declares #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 22 commits into from
Dec 19, 2022
Merged

Set up the Swift version the extractor declares #1422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2474e31
Unconditionally setup Swift 5.7.1
angelapwen Dec 8, 2022
4d8bc9a
Set up Swift version from extractor
angelapwen Dec 8, 2022
50fd9ed
Always setup 5.7.1, stop testing cached for Swift
angelapwen Dec 14, 2022
31aec7e
Set up Swift version extractor declares after `init`
angelapwen Dec 15, 2022
20b2d99
Update CodeQL Path in PR checks
angelapwen Dec 16, 2022
bf7b57a
Replace checks for cached
angelapwen Dec 16, 2022
f98790d
Update variable assignment
angelapwen Dec 16, 2022
ae01aeb
Set Swift env variable globally
angelapwen Dec 16, 2022
bf101af
Test resolve languages command
angelapwen Dec 16, 2022
8abe7d8
Simply print the Swift extractor dir
angelapwen Dec 16, 2022
f57b19c
Only check Swift version for latest CLIs
angelapwen Dec 16, 2022
b72cfb6
Update with correct extractor path
angelapwen Dec 16, 2022
4efa340
Use correct platform for extractor
angelapwen Dec 16, 2022
c50429d
Specify v5.7.0 rather than 5.7
angelapwen Dec 16, 2022
e605467
Address review comments
angelapwen Dec 16, 2022
8b813b9
Add prepare-test step to composite action
angelapwen Dec 17, 2022
3dcfa89
Change dir instead of re-running prepare test
angelapwen Dec 17, 2022
eeabe6a
Print directory after Swift setup Action
angelapwen Dec 17, 2022
b44d043
Stop checking out repo again
angelapwen Dec 17, 2022
bfbd05f
Use proper file path for setup swift
angelapwen Dec 19, 2022
609cafe
Update .github/setup-swift/action.yml
angelapwen Dec 19, 2022
e49ccec
Update file path for setup-swift
angelapwen Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only check Swift version for latest CLIs
  • Loading branch information
@angelapwen
angelapwen committed Dec 16, 2022
commit f57b19c508a181e2b2e215611f76a2128eb81199
8 changes: 6 additions & 2 deletions .github/workflows/__multi-language-autodetect.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pr-checks/checks/multi-language-autodetect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ steps:

- name: Get Swift version
id: get_swift_version
if: "(matrix.version == 'cached' || matrix.version == 'latest' || matrix.version == 'nightly-latest')"
shell: bash
env:
CODEQL_PATH: ${{steps.init.outputs.codeql-path}}
Expand All @@ -22,6 +23,7 @@ steps:
echo "version=$VERSION" | tee -a $GITHUB_OUTPUT

- uses: swift-actions/setup-swift@194625b58a582570f61cc707c3b558086c26b723
if: "(matrix.version == 'cached' || matrix.version == 'latest' || matrix.version == 'nightly-latest')"
with:
swift-version: "${{steps.get_swift_version.outputs.version}}"

Expand Down Expand Up @@ -77,7 +79,7 @@ steps:
fi

- name: Check language autodetect for Swift
if: "!startsWith(matrix.os, 'windows') && (matrix.version == 'cached' || matrix.version == 'latest' || matrix.version == 'nightly-latest')"
Copy link
Contributor

@adityasharad adityasharad Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the Windows check here because we haven't put any Windows versions in the matrix?

Copy link
Contributor Author

@angelapwen angelapwen Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes — but I've actually added it back in the composite action as that might be run from a Windows workflow!

if: "(matrix.version == 'cached' || matrix.version == 'latest' || matrix.version == 'nightly-latest')"
shell: bash
run: |
SWIFT_DB=${{ fromJson(steps.analysis.outputs.db-locations).swift }}
Expand Down