Skip to content

Ensure qlconfig file is created when config parsing in cli is on #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeisenberg merged 7 commits into from
Feb 27, 2023
Merged

Ensure qlconfig file is created when config parsing in cli is on #1527

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bbe8d37
Ensure qlconfig file is created when config parsing in cli is on
aeisenberg Feb 7, 2023
e2f72f1
Merge remote-tracking branch 'upstream/main' into aeisenberg/qlconfig…
aeisenberg Feb 9, 2023
3c81243
Apply suggestions from code review
aeisenberg Feb 9, 2023
5492b7d
Add tests for `generateRegistries` with an existing CODEQL_REGISTRIES…
aeisenberg Feb 9, 2023
736263f
Update src/codeql.ts
aeisenberg Feb 17, 2023
8f19113
Merge branch 'main' into aeisenberg/qlconfig-in-cli
aeisenberg Feb 27, 2023
98d24e5
Address comments from PR
aeisenberg Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ensure qlconfig file is created when config parsing in cli is on 
Previously, with the config parsing in the cli feature flag turned on,
the CLI was not able to download packs from other registries. This PR
adds the codeql-action changes required for this. The CLI changes will
be in a separate, internal PR.
  • Loading branch information
@aeisenberg
aeisenberg committed Feb 7, 2023
commit bbe8d375fde0b57cca00481fc70d1b0d38ddcaea
42 changes: 42 additions & 0 deletions .github/workflows/__init-with-registries.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map
View file
Open in desktop

Large diffs are not rendered by default.

51 changes: 31 additions & 20 deletions lib/codeql.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.test.js.map
View file
Open in desktop

Large diffs are not rendered by default.

61 changes: 42 additions & 19 deletions lib/config-utils.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/config-utils.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading