Skip to content

Improve automation for updating supported versions of GHES #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 5 commits into from
May 31, 2023
Merged

Improve automation for updating supported versions of GHES #1711

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07e43a2
Open PR with gh CLI
henrymercer May 31, 2023
afdba76
Wait a week before dropping support for end of life GHES versions
henrymercer May 31, 2023
e7cff66
Fix push
henrymercer May 31, 2023
955f859
Fix sign error
henrymercer May 31, 2023
26f16a5
Rephrase the still supported calculation to make it clearer
henrymercer May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rephrase the still supported calculation to make it clearer
  • Loading branch information
@henrymercer
henrymercer committed May 31, 2023
commit 26f16a5e63c7bebdcf17b2a6d1c7fc1861a0c611
3 changes: 2 additions & 1 deletion .github/workflows/update-supported-enterprise-server-versions/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ def main():
end_of_life_date = datetime.date.fromisoformat(release_data["end"])
# The GHES version is not actually end of life until the end of the day specified by
# `end_of_life_date`. Wait an extra week to be safe.
if end_of_life_date > datetime.date.today() - datetime.timedelta(weeks=1):
is_end_of_life = datetime.date.today() > end_of_life_date + datetime.timedelta(weeks=1)
if not is_end_of_life:
oldest_supported_release = release_version

api_compatibility_data = {
Expand Down