Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
9953504
Use new packaging mechanism for internal queries
henrymercer May 11, 2023
abb267d
Add query to identify env vars that may not work with default setup
henrymercer May 11, 2023
8065746
Add query to find context variables that may not work with default setup
henrymercer May 12, 2023
eac5e24
Downgrade query severity to warning
henrymercer May 16, 2023
292bb7c
Parameterize check scripts over requests version
henrymercer May 23, 2023
6e92b19
Bump requests to 2.31.0
henrymercer May 23, 2023
4f41ff7
Update default bundle to codeql-bundle-20230524
invalid-email-address May 24, 2023
34e8e09
Add changelog note
invalid-email-address May 24, 2023
143b5fb
Merge branch 'main' into henrymercer/update-requests
henrymercer May 24, 2023
60f5c59
Merge branch 'main' into update-bundle/codeql-bundle-20230524
henrymercer May 24, 2023
65920dd
Unconditionally set up Swift in debug artifacts PR check
henrymercer May 24, 2023
339e0d5
Update changelog and version after v2.3.5
github-actions[bot] May 25, 2023
1ba7713
Update checked-in dependencies
github-actions[bot] May 25, 2023
2d031a3
Merge pull request #1707 from github/mergeback/v2.3.5-to-main-0225834c
aeisenberg May 25, 2023
f8b1cb6
Merge pull request #1695 from github/henrymercer/update-requests
henrymercer May 26, 2023
2408985
Only print lines of code information once
henrymercer May 26, 2023
6bd8101
Merge pull request #1709 from github/henrymercer/print-baseline-once
henrymercer May 26, 2023
eb1c7a3
Use `getRefFromEnv()` so ref is present on default setup
henrymercer May 30, 2023
86ead5e
Only flag up the deepest properties
henrymercer May 30, 2023
125ff55
Fix deprecation warnings
henrymercer May 30, 2023
d427c89
Ignore internal Actions
henrymercer May 30, 2023
9d2dd7c
Merge pull request #1698 from github/update-bundle/codeql-bundle-2023…
May 31, 2023
9632771
Address review comments
henrymercer May 31, 2023
07e43a2
Open PR with gh CLI
henrymercer May 31, 2023
afdba76
Wait a week before dropping support for end of life GHES versions
henrymercer May 31, 2023
e7cff66
Fix push
henrymercer May 31, 2023
955f859
Fix sign error
henrymercer May 31, 2023
26f16a5
Rephrase the still supported calculation to make it clearer
henrymercer May 31, 2023
89c4c9e
Merge pull request #1678 from github/henrymercer/default-setup-safegu…
henrymercer May 31, 2023
96f2840
Merge pull request #1711 from github/henrymercer/improve-supported-ve…
henrymercer May 31, 2023
5c8f4be
Update changelog for v2.3.6
github-actions[bot] Jun 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/python-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:

- name: Verify packages installed
run: |
$GITHUB_WORKSPACE/python-setup/tests/check_requests_2_26_0.sh ${PYTHON_VERSION}
$GITHUB_WORKSPACE/python-setup/tests/check_requests.sh ${PYTHON_VERSION} 2.31.0

# This one shouldn't fail, but also won't install packages
test-setup-python-scripts-non-standard-location:
Expand Down Expand Up @@ -170,5 +170,5 @@ jobs:

- name: Verify packages installed
run: |
$cmd = $Env:GITHUB_WORKSPACE + "\\python-setup\\tests\\check_requests_2_26_0.ps1"
powershell -File $cmd $Env:PYTHON_VERSION
$cmd = $Env:GITHUB_WORKSPACE + "\\python-setup\\tests\\check_requests.ps1"
powershell -File $cmd $Env:PYTHON_VERSION 2.31.0
27 changes: 27 additions & 0 deletions python-setup/tests/check_requests.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#! /usr/bin/pwsh

$EXPECTED_PYTHON_VERSION=$args[0]
$EXPECTED_REQUESTS_VERSION=$args[1]

$FOUND_PYTHON_VERSION="$Env:LGTM_PYTHON_SETUP_VERSION"
$FOUND_PYTHONPATH="$Env:LGTM_INDEX_IMPORT_PATH"

write-host "FOUND_PYTHON_VERSION=$FOUND_PYTHON_VERSION FOUND_PYTHONPATH=$FOUND_PYTHONPATH "

if ($FOUND_PYTHON_VERSION -ne $EXPECTED_PYTHON_VERSION) {
write-host "Script told us to use Python $FOUND_PYTHON_VERSION, but expected $EXPECTED_PYTHON_VERSION"
exit 1
} else {
write-host "Script told us to use Python $FOUND_PYTHON_VERSION, which was expected"
}

$env:PYTHONPATH=$FOUND_PYTHONPATH

$INSTALLED_REQUESTS_VERSION = (py -3 -c "import requests; print(requests.__version__)")

if ($INSTALLED_REQUESTS_VERSION -ne $EXPECTED_REQUESTS_VERSION) {
write-host "Using $FOUND_PYTHONPATH as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, but expected $EXPECTED_REQUESTS_VERSION"
exit 1
} else {
write-host "Using $FOUND_PYTHONPATH as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, which was expected"
}
31 changes: 31 additions & 0 deletions python-setup/tests/check_requests.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#!/bin/bash

set -e

SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

EXPECTED_PYTHON_VERSION=$1
EXPECTED_REQUESTS_VERSION=$2

FOUND_PYTHON_VERSION="$LGTM_PYTHON_SETUP_VERSION"
FOUND_PYTHONPATH="$LGTM_INDEX_IMPORT_PATH"

echo "FOUND_PYTHON_VERSION=${FOUND_PYTHON_VERSION} FOUND_PYTHONPATH=${FOUND_PYTHONPATH} "

if [[ $FOUND_PYTHON_VERSION != $EXPECTED_PYTHON_VERSION ]]; then
echo "Script told us to use Python ${FOUND_PYTHON_VERSION}, but expected ${EXPECTED_PYTHON_VERSION}"
exit 1
else
echo "Script told us to use Python ${FOUND_PYTHON_VERSION}, which was expected"
fi

PYTHON_EXE="python${EXPECTED_PYTHON_VERSION}"

INSTALLED_REQUESTS_VERSION=$(PYTHONPATH="${FOUND_PYTHONPATH}" "${PYTHON_EXE}" -c 'import requests; print(requests.__version__)')

if [[ "$INSTALLED_REQUESTS_VERSION" != "$EXPECTED_REQUESTS_VERSION" ]]; then
echo "Using ${FOUND_PYTHONPATH} as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, but expected $EXPECTED_REQUESTS_VERSION"
exit 1
else
echo "Using ${FOUND_PYTHONPATH} as PYTHONPATH, we found version $INSTALLED_REQUESTS_VERSION of requests, which was expected"
fi
28 changes: 0 additions & 28 deletions python-setup/tests/check_requests_2_26_0.ps1

This file was deleted.

32 changes: 0 additions & 32 deletions python-setup/tests/check_requests_2_26_0.sh

This file was deleted.

105 changes: 89 additions & 16 deletions python-setup/tests/pipenv/python-3.8/Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading