Skip to content

Refactor configuration errors #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 17 commits into from
Feb 8, 2024
Merged

Refactor configuration errors #2105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1c5a7b0
Refactor existing CLI errors into new class
angelapwen Jan 30, 2024
b5dd04b
Move config error processing for `database init`
angelapwen Jan 30, 2024
34d760d
Fix config error checking condition
angelapwen Jan 30, 2024
7fa31b7
Add `processCliConfigurationError` method
angelapwen Jan 31, 2024
011aa0d
Combine action error text into original configuration `Record`
angelapwen Jan 31, 2024
a84ad63
Rename `UserError` to `ConfigurationError`
angelapwen Jan 31, 2024
8c539c5
Clarify `CliErrorCategory`
angelapwen Feb 5, 2024
fb9a552
Refactor configuration error parsing logic per review
angelapwen Feb 6, 2024
8812654
Fix up tests
angelapwen Feb 6, 2024
b62de8d
Rename to `cli-errors`, clean up logging and comments
angelapwen Feb 6, 2024
a6cb48e
Clarify comment from PR review
angelapwen Feb 6, 2024
d64851b
Rename variable for clarity
angelapwen Feb 6, 2024
4382429
Remove transpiled files
angelapwen Feb 6, 2024
c78e96b
Throw `e` even if not an `Error`
angelapwen Feb 7, 2024
a2c26c9
Rename enum variables per PR review
angelapwen Feb 8, 2024
bcad4f7
Merge branch 'main' into refactor-config-errors
angelapwen Feb 8, 2024
49b80d0
Resolve merge conflict
angelapwen Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix up tests 
Now that we are always appending the original error, this test needs to be updated.
  • Loading branch information
@angelapwen
angelapwen committed Feb 6, 2024
commit 8812654ad80f5b5f0509cb60f09332a95d5a7fab
10 changes: 6 additions & 4 deletions lib/codeql.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading