Skip to content

improve logging coverage during sarif upload #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickfyson merged 7 commits into from
Apr 4, 2024
Merged

improve logging coverage during sarif upload #2221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6514cbb
improve logging coverage when uploaing sarif files
nickfyson Apr 3, 2024
2cc8bbd
Apply suggestions from code review
nickfyson Apr 3, 2024
978bdd6
fix test that runs flakily locally
nickfyson Apr 3, 2024
d325762
fix linting error
nickfyson Apr 3, 2024
2654062
Merge branch 'main' into nickfyson/upload-logging
nickfyson Apr 3, 2024
d3c32a8
fix test to respect updated logging behaviour
nickfyson Apr 3, 2024
c037115
clarify logging in response to pr review comments
nickfyson Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Henry Mercer <[email protected]>
  • Loading branch information
@nickfyson @henrymercer
nickfyson and henrymercer committed Apr 3, 2024
commit 2cc8bbd0e0d40ad79a415789884bb51a1db7b806
2 changes: 1 addition & 1 deletion lib/fingerprints.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/fingerprints.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading