Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
ca7f194
Avoid warning on workflow_call triggers
aeisenberg May 6, 2024
e50fb8f
Add a compatibility table to the README
aeisenberg May 6, 2024
ec11790
Add user error for "Pack cannot be found"
henrymercer May 8, 2024
45fb58a
Add user error for gracefully running out of memory
henrymercer May 8, 2024
a21528b
Update changelog and version after v3.25.4
github-actions[bot] May 8, 2024
b1c3187
Add more invalid SARIF processing errors
henrymercer May 8, 2024
65c9ae9
Update checked-in dependencies
github-actions[bot] May 8, 2024
2c25369
Run release process using Python 3.12
henrymercer May 8, 2024
e36d338
Merge pull request #2276 from github/mergeback/v3.25.4-to-main-ccf74c94
henrymercer May 8, 2024
7aff39e
Merge pull request #2279 from github/henrymercer/python-3.12
henrymercer May 8, 2024
715d348
Merge pull request #2277 from github/henrymercer/more-user-errors
henrymercer May 8, 2024
7d9b7a1
Merge pull request #2274 from github/aeisenberg/no-warn-workflow_call
aeisenberg May 8, 2024
43beef6
Update README.md
aeisenberg May 8, 2024
9fba755
Merge branch 'main' into aeisenberg/specify-versions
aeisenberg May 8, 2024
d234275
Move changelog notes to proper section
aeisenberg May 8, 2024
c49579b
Add support for on-demand feature flags
henrymercer May 9, 2024
9dc84e9
Log feature flags on separate lines in debug mode
henrymercer May 9, 2024
cf4c3b4
Remove "_enabled" suffix from non-legacy features
henrymercer May 9, 2024
7a6352f
Don't call `trace-command` when the indirect tracer has already been …
henrymercer May 9, 2024
5ac5c91
End tracing early in autobuild Action for improved performance and re…
henrymercer May 9, 2024
def4d2c
Merge pull request #2273 from github/aeisenberg/specify-versions
aeisenberg May 9, 2024
4995c49
Merge pull request #2282 from github/henrymercer/no-build-mode-tracin…
henrymercer May 10, 2024
67f8a36
Merge branch 'main' into henrymercer/on-demand-ffs
henrymercer May 10, 2024
33e416c
Comment that `legacyApi` is false by default
henrymercer May 10, 2024
c59e052
Disable fail fast in generated workflows
henrymercer May 10, 2024
f73b0b7
Disable fail fast for non-generated workflows
henrymercer May 10, 2024
a8c32fd
Merge pull request #2283 from github/henrymercer/disable-fail-fast
henrymercer May 10, 2024
4a51972
Merge pull request #2280 from github/henrymercer/on-demand-ffs
henrymercer May 10, 2024
6778fe4
Update changelog for v3.25.5
github-actions[bot] May 13, 2024
b7cec75
Merge pull request #2287 from github/update-v3.25.5-4a5197247
henrymercer May 13, 2024
3471008
Revert "Update version and changelog for v2.25.4"
henrymercer May 13, 2024
ceb635d
Revert "Update checked-in dependencies"
henrymercer May 13, 2024
b5e604a
Merge remote-tracking branch 'origin/releases/v3' into backport-v2.25…
henrymercer May 13, 2024
a953717
Update version and changelog for v2.25.5
henrymercer May 13, 2024
78d1334
Update checked-in dependencies
github-actions[bot] May 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't call trace-command when the indirect tracer has already been …
…started
  • Loading branch information
henrymercer committed May 9, 2024
commit 7a6352f8e603d76b0ad7f0e38d0f89c4bfc7a173
2 changes: 1 addition & 1 deletion lib/autobuild.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/autobuild.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 1 addition & 12 deletions lib/codeql.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/codeql.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.test.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/autobuild.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export async function runAutobuild(
) {
await codeQL.extractUsingBuildMode(config, language);
} else {
await codeQL.runAutobuild(config, language, features);
await codeQL.runAutobuild(config, language);
}
if (language === Language.go) {
core.exportVariable(EnvVar.DID_AUTOBUILD_GOLANG, "true");
Expand Down
14 changes: 2 additions & 12 deletions src/codeql.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -910,12 +910,7 @@ test("runTool summarizes autobuilder errors", async (t) => {
sinon.stub(safeWhich, "safeWhich").resolves("");

await t.throwsAsync(
async () =>
await codeqlObject.runAutobuild(
stubConfig,
Language.java,
createFeatures([]),
),
async () => await codeqlObject.runAutobuild(stubConfig, Language.java),
{
instanceOf: CommandInvocationError,
message:
Expand Down Expand Up @@ -943,12 +938,7 @@ test("runTool truncates long autobuilder errors", async (t) => {
sinon.stub(safeWhich, "safeWhich").resolves("");

await t.throwsAsync(
async () =>
await codeqlObject.runAutobuild(
stubConfig,
Language.java,
createFeatures([]),
),
async () => await codeqlObject.runAutobuild(stubConfig, Language.java),
{
instanceOf: CommandInvocationError,
message:
Expand Down
26 changes: 2 additions & 24 deletions src/codeql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,7 @@ export interface CodeQL {
/**
* Runs the autobuilder for the given language.
*/
runAutobuild(
config: Config,
language: Language,
features: FeatureEnablement,
): Promise<void>;
runAutobuild(config: Config, language: Language): Promise<void>;
/**
* Extract code for a scanned language using 'codeql database trace-command'
* and running the language extractor.
Expand Down Expand Up @@ -634,27 +630,9 @@ export async function getCodeQLForCmd(
{ stdin: externalRepositoryToken },
);
},
async runAutobuild(
config: Config,
language: Language,
features: FeatureEnablement,
) {
async runAutobuild(config: Config, language: Language) {
applyAutobuildAzurePipelinesTimeoutFix();

if (
await features.getValue(Feature.AutobuildDirectTracingEnabled, this)
) {
await runTool(cmd, [
"database",
"trace-command",
...(await getTrapCachingExtractorConfigArgsForLang(config, language)),
...getExtractionVerbosityArguments(config.debugMode),
...getExtraOptionsFromEnv(["database", "trace-command"]),
util.getCodeQLDatabasePath(config, language),
]);
return;
}

const autobuildCmd = path.join(
await this.resolveExtractor(language),
"tools",
Expand Down