Skip to content

Fix incompatibility between direct tracing in the autobuild Action and specifying a custom working directory #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 8 commits into from
Jun 13, 2024
Merged

Fix incompatibility between direct tracing in the autobuild Action and specifying a custom working directory #2328

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
599f279
Bump the feature flag version for direct tracing autobuild
henrymercer Jun 11, 2024
6d62742
Pass `working-directory` input to `trace-command` invocation
henrymercer Jun 11, 2024
b004bb4
Add PR check for direct tracing with custom working directory
henrymercer Jun 11, 2024
12243c7
Disable database upload in test mode
henrymercer Jun 11, 2024
485d096
Update upload-sarif ref/sha input test
henrymercer Jun 11, 2024
ba4e487
Update `checkout_path` test
henrymercer Jun 11, 2024
94acfdc
Upload SARIF with ref/sha inputs: Generate SARIF with analyze Action
henrymercer Jun 11, 2024
f2ea211
Merge branch 'main' into henrymercer/direct-tracing-fix
henrymercer Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update checkout_path test 
Just call `analyze`, since `upload: never` skips most of the functionality we want to test anyway.
  • Loading branch information
@henrymercer
henrymercer committed Jun 11, 2024
commit ba4e487a2cef5a9cf0c67f4551be762844f0f2f1
6 changes: 0 additions & 6 deletions .github/workflows/__with-checkout-path.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions pr-checks/checks/with-checkout-path.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,6 @@ steps:
ref: v1.1.0
sha: 474bbf07f9247ffe1856c6a0f94aeeb10e7afee6

- uses: ./../action/upload-sarif
with:
ref: v1.1.0
sha: 474bbf07f9247ffe1856c6a0f94aeeb10e7afee6
checkout_path: x/y/z/some-path/tests/multi-language-repo

- name: Verify SARIF after upload
shell: bash
run: |
Expand Down