Skip to content

Only run check SIP enablement once in init step #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 5 commits into from
Aug 23, 2024
Merged

Only run check SIP enablement once in init step #2441

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72f3573
Only run check SIP enablement once in `init` step
angelapwen Aug 22, 2024
7140659
Add CHANGELOG entry
angelapwen Aug 22, 2024
bd123c8
Add stricter check for environment variable value
angelapwen Aug 23, 2024
1570300
Update src/util.ts
angelapwen Aug 23, 2024
b406044
Rebuild
github-actions[bot] Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/util.ts 
Co-authored-by: Henry Mercer <[email protected]>
  • Loading branch information
@angelapwen @henrymercer
angelapwen and henrymercer authored Aug 23, 2024
commit 1570300a540a7319f0a1463897aabb11ba8e2de6
2 changes: 1 addition & 1 deletion src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ export async function checkSipEnablement(
): Promise<boolean | undefined> {
if (
process.env[EnvVar.IS_SIP_ENABLED] !== undefined &&
process.env[EnvVar.IS_SIP_ENABLED] in ["true", "false"]
["true", "false"].includes(process.env[EnvVar.IS_SIP_ENABLED])
) {
return process.env[EnvVar.IS_SIP_ENABLED] === "true";
}
Expand Down