Skip to content

Ensure artifacts are only uploaded in safe situations #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeisenberg merged 7 commits into from
Jan 27, 2025
Merged

Ensure artifacts are only uploaded in safe situations #2726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2bab9f7
Ensure artifacts are only uploaded in safe situations
aeisenberg Jan 25, 2025
5ff2464
Update changelog
aeisenberg Jan 25, 2025
f71067b
Stop using feature-flag support for determining if a feature is active
aeisenberg Jan 26, 2025
346d067
Fix CLI versions
aeisenberg Jan 27, 2025
a2c1b36
Iterate over each version
aeisenberg Jan 27, 2025
62c322f
Add better comments around artifact upload tests
aeisenberg Jan 27, 2025
a879704
Clarify test fail;ure message
aeisenberg Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stop using feature-flag support for determining if a feature is active 
Using the feature flag mechanism for checking if uploads are enabled was
too clunky. I'm moving the change to checking versions directly.
  • Loading branch information
@aeisenberg
aeisenberg committed Jan 26, 2025
commit f71067bd5fb707b07fe8ada494e369fad3865847
13 changes: 4 additions & 9 deletions lib/analyze-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action-post.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 8 additions & 10 deletions lib/debug-artifacts.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading