Skip to content

feat: further error re-classification #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NlightNFotis merged 11 commits into from
Apr 2, 2025
Merged

feat: further error re-classification #2833

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3c42562
fix: update comment for test to state correct expected outcome
NlightNFotis Mar 31, 2025
a022653
feat: classify more HTTP errors as configuration errors in api-client
NlightNFotis Mar 31, 2025
72a2b12
feat: classify some observed SARIF errors as InvalidSarifUploadError
NlightNFotis Mar 31, 2025
f21cf0b
feat: reclassify InvalidSarifUploadError as a user-error when final s…
NlightNFotis Mar 31, 2025
01f1a1f
Merge branch 'main' into NlightNFotis/reclassify_upload_sarif_issues
NlightNFotis Mar 31, 2025
55ee663
review-comments: refactor getActionsStatus to accept an extra paramet…
NlightNFotis Apr 1, 2025
b53826d
review-comments: remove syntax-error handling for SARIF from upload-lib
NlightNFotis Apr 1, 2025
efd29be
refactor: revert getActionsStatus taking an extra argument
NlightNFotis Apr 2, 2025
498c7f3
review-comments: unwrap error in upload-sarif-action and re-classify …
NlightNFotis Apr 2, 2025
676a422
review-comments: nest validateSariFileSchema into try-catch block to …
NlightNFotis Apr 2, 2025
06703ce
Merge branch 'main' into NlightNFotis/reclassify_upload_sarif_issues
NlightNFotis Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review-comments: refactor getActionsStatus to accept an extra paramet… 
…er designating if the analysis is third-party
  • Loading branch information
@NlightNFotis
NlightNFotis committed Apr 1, 2025
commit 55ee663d5f438278289baa303efa7a22e417c9ea
3 changes: 2 additions & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions lib/api-client.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/api-client.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions lib/api-client.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading