Skip to content

Overlay: Fall back to full analysis if runner disk space is low #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaspersv merged 4 commits into from
Nov 19, 2025
Merged

Overlay: Fall back to full analysis if runner disk space is low #3310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f746e4
Overlay: Fall back to full analysis if runner disk space is low
kaspersv Nov 18, 2025
726a2a0
Overlay: Increase disk storage threshold to 20GB
kaspersv Nov 18, 2025
ed80d6e
Overlay: Reorder available disk space check
kaspersv Nov 19, 2025
4eccb37
Overlay: Round available disk space in MB
kaspersv Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Overlay: Reorder available disk space check
  • Loading branch information
@kaspersv
kaspersv committed Nov 19, 2025
commit ed80d6e5e959958d907c93c7e350411df87b57aa
14 changes: 7 additions & 7 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions src/config-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,14 @@ export async function getOverlayDatabaseMode(
`Setting overlay database mode to ${overlayDatabaseMode} ` +
"from the CODEQL_OVERLAY_DATABASE_MODE environment variable.",
);
} else {
} else if (
await isOverlayAnalysisFeatureEnabled(
features,
codeql,
languages,
codeScanningConfig,
)
) {
const diskUsage = await checkDiskUsage(logger);
if (
diskUsage === undefined ||
Expand All @@ -693,14 +700,7 @@ export async function getOverlayDatabaseMode(
`Setting overlay database mode to ${overlayDatabaseMode} ` +
`due to insufficient disk space (${diskSpaceMb} MB).`,
);
} else if (
await isOverlayAnalysisFeatureEnabled(
features,
codeql,
languages,
codeScanningConfig,
)
) {
} else {
if (isAnalyzingPullRequest()) {
overlayDatabaseMode = OverlayDatabaseMode.Overlay;
useOverlayDatabaseCaching = true;
Expand Down