Skip to content

Analyze: Improve log grouping and log the analysis summary in its own group #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityasharad merged 5 commits into from
May 20, 2021
Merged

Analyze: Improve log grouping and log the analysis summary in its own group #515

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19fe63f
Analyze: Log the analysis summary in its own group
adityasharad May 19, 2021
031ec87
Group log messages while uploading results
adityasharad May 20, 2021
741bd73
Changelog: Add note for grouping of analysis logs
adityasharad May 20, 2021
512d467
Decode CodeQL stdout as UTF-8
adityasharad May 20, 2021
f84cc5e
Fix trailing newline in package.json
adityasharad May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Group log messages while uploading results
  • Loading branch information
@adityasharad
adityasharad committed May 20, 2021
commit 031ec8753a33d550bac8f7e29e50a2c0fc6f47b6
4 changes: 3 additions & 1 deletion lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/upload-lib.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/upload-lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ async function uploadFiles(
mode: util.Mode,
logger: Logger
): Promise<UploadStatusReport> {
logger.info(`Uploading sarif files: ${JSON.stringify(sarifFiles)}`);
logger.startGroup("Uploading results");
logger.info(`Processing sarif files: ${JSON.stringify(sarifFiles)}`);

if (mode === "actions") {
// This check only works on actions as env vars don't persist between calls to the runner
Expand Down Expand Up @@ -403,6 +404,8 @@ async function uploadFiles(
// Make the upload
await uploadPayload(payload, repositoryNwo, apiDetails, mode, logger);

logger.endGroup();

return {
raw_upload_size_bytes: rawUploadSizeBytes,
zipped_upload_size_bytes: zippedUploadSizeBytes,
Expand Down