Skip to content

Update README.md #18927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2022
Merged

Update README.md #18927

merged 3 commits into from
Jul 11, 2022

Conversation

@prasadjivane
Copy link
Contributor

@prasadjivane prasadjivane commented Jul 4, 2022 •
edited
Loading

Why:

Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Jul 4, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 4, 2022
@Aizmansor

This comment was marked as spam.

Sign in to view
@cmwilson21
Copy link
Contributor

cmwilson21 commented Jul 11, 2022

@prasadjivane Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review! ⚡

@prasadjivane
Copy link
Contributor Author

prasadjivane commented Jul 11, 2022

@cmwilson21, Done..!

@cmwilson21
Copy link
Contributor

cmwilson21 commented Jul 11, 2022

@prasadjivane I'll get this triaged for review. On future PR's, we would appreciate it if you would fill out the information in the PR template including the "Why" section and including the link to an open issue that the PR fixes. If there isn't one, we encourage users to always open an issue first, then make their PR and link the two, as this helps us in our review process. See our contributing.md for more information. 💖

Thank you for your passion in improving our docs! ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Jul 11, 2022
@cmwilson21 cmwilson21 self-requested a review July 11, 2022 20:45
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jul 11, 2022
cmwilson21
cmwilson21 reviewed Jul 11, 2022
View reviewed changes
@cmwilson21
Update README.md
fa9d0d2 
added the comma back in
cmwilson21
cmwilson21 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the missing word and correcting it! I'll get this merged once all the tests are passing ⚡

@cmwilson21
Copy link
Contributor

cmwilson21 commented Jul 11, 2022

I did add the comma back to the first suggested change. We use the Oxford comma per our content guide. You can find more information about that here.

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Jul 11, 2022
@cmwilson21 cmwilson21 merged commit 3ab62e6 into github:main Jul 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prasadjivane @Aizmansor @cmwilson21