Skip to content

handle windows paths in product definitions #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

handle windows paths in product definitions #351

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c906187
handle windows paths in product definitions
jeffmcaffer Oct 9, 2020
2c60222
Merge branch 'main' into jeffmcaffer-patch-5
chiedo Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
handle windows paths in product definitions
  • Loading branch information
@jeffmcaffer
jeffmcaffer authored Oct 9, 2020
commit c906187cf7562cf5353085f8863f671314e7ca24
7 changes: 4 additions & 3 deletions lib/all-products.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const fs = require('fs')
const path = require('path')
const slash = require('slash')
const assert = require('assert')
const { difference } = require('lodash')
const yaml = require('js-yaml')
Expand All @@ -23,11 +24,11 @@ const internalProducts = {}

sortedProductIds.forEach(productId => {
const relPath = productId
const dir = path.join('content', relPath)
const toc = path.join(dir, 'index.md')
const dir = slash(path.join('content', relPath))
const toc = slash(path.join(dir, 'index.md'))
const { data } = frontmatter(fs.readFileSync(toc, 'utf8'))
const applicableVersions = getApplicableVersions(data.versions, toc)
const href = path.join('/', applicableVersions[0], productId)
const href = slash(path.join('/', applicableVersions[0], productId))

internalProducts[productId] = {
id: productId,
Expand Down